Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP]Add support for NODEFS#439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
fanthos wants to merge11 commits intosql-js:master
base:master
Choose a base branch
Loading
fromfanthos:master
Open

Conversation

@fanthos
Copy link

Export FS to outer module to allow custom mount filesystem.
Link and export NODEFS to allow mount NODEFS on emscripten virtual fs.

@fanthosfanthos changed the titleAdd nodefs to MakefileAdd support for NODEFSMar 1, 2021
@fanthosfanthos changed the titleAdd support for NODEFS[WIP]Add support for NODEFSMar 1, 2021
@fanthosfanthos changed the title[WIP]Add support for NODEFSAdd support for NODEFSMar 1, 2021
@lovasoa
Copy link
Member

May I ask what exactly is your use case for sql.js on node.js ? sql.js is slower, more limited, and uses more memory than a native sqlite. If you are working on both node and the browser, I would suggest writing a small abstraction layer that can talk to eithernative SQLite or sql.js depending on the platform. There isn't really any point in running sql.js on node.

@fanthosfanthos changed the titleAdd support for NODEFS[WIP]Add support for NODEFSMar 1, 2021
@fanthos
Copy link
Author

I have a project running nodejs on different processor and operating system, including MIPS and x86, so making code portable might be helpful for this.
Currently the tests passed on debug mode.

@lovasoa
Copy link
Member

SQLite is an extremely portable piece of software. It should work without issue on almost any architecture. Especially if you plan to run on less powerful hardware, I would encourage you to use a native solution.

@fanthos
Copy link
Author

The code works good without Closure Compiler, but I have no idea how Closure Compiler breaks it.

@fanthos
Copy link
Author

Compressingsql-asm-debug.js withuglify-js -m option result a 2,493kb file and all tests passed.

@davidvedvick
Copy link

Please consider this change again! One benefit of this capability is that if you're on a shared host your host can upgrade the underlying NodeJS version without you having to recompile SQLite bindings. Right now I need to re-build my SQLite packages when NearlyFreeSpeech.NET moves to the next NodeJS LTS version. If I'm not on my toes, my site could be down for some time (obviously, this is not mission critical for me, but could be for others).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fanthos@lovasoa@davidvedvick

[8]ページ先頭

©2009-2025 Movatter.jp