- Notifications
You must be signed in to change notification settings - Fork1.1k
[RFC] support build with custom (non-standard) functions#320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
brody4hire wants to merge1 commit intosql-js:masterChoose a base branch frombrody4hire:custom-functions
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
for custom (non-standard) SQLite3 extension functions that may beadded in the futurewith some additional explanatory comments added to the CoffeeScript
06f6789
to6a20a45
Comparebrody4hire referenced this pull request in brody4hire/sql.jsJan 13, 2020
for custom (non-standard) SQLite3 extension functions that may beadded in the futurewith some additional explanatory comments added to the CoffeeScriptas proposed in:https://github.com/kripken/sql.js/pull/320
brody4hire referenced this pull request in brody4hire/sql.jsJan 13, 2020
for custom (non-standard) SQLite3 extension functions that may beadded in the futurewith some additional explanatory comments added to the CoffeeScriptas proposed in:https://github.com/kripken/sql.js/pull/320
brody4hire referenced this pull request in brody4hire/sql.jsJan 13, 2020
for custom (non-standard) SQLite3 extension functions that may beadded in the futurewith some additional explanatory comments added to the CoffeeScriptas proposed in:https://github.com/kripken/sql.js/pull/320
This was referencedFeb 18, 2020
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just an idea of how it may be possible to support developers who need to build with non-standard functions. Here is an example where I support UPPER and LOWER functions that can handle many EU characters properly:https://github.com/brodybits/sql.js/tree/custom-eu-string-functions
This idea includes some comments that I think should be considered in
src/api.coffee
that can help make it easier for people like myself to add custom functions in the future.I suspect there should be a much smarter way to do this, by using an array of FuncDef structures like they do in
extension-functions.c
for example.I will very likely continue with the kind of solution proposed here to support the needs of my customer, with hope for a more standardized solution (someday).