Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add ability to define the size of the database in the constructor#298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
missvalentinep wants to merge2 commits intosql-js:master
base:master
Choose a base branch
Loading
fromgemini-testing:html-reporter

Conversation

@missvalentinep
Copy link

When we have to work with big data, the ability to predefine the size of a new database can significantly speed up script execution time, because multiple calls to MEMF.expandFileStorage is way less efficient than one "bigger" call to it.

JavaScript profile of merging 7 databases (each of size ~15 MB) into one, without expanding the final db file first
Screen Shot 2019-10-03 at 10 51 31 AM

The same operation but with expanding the final database to the size of (sum of 7 databases' sizes)
Screen Shot 2019-10-03 at 10 52 01 AM

miripiruni reacted with thumbs up emojibrody4hire reacted with eyes emoji
@missvalentinepmissvalentinep changed the titleadd ability to define the size of the database the constructoradd ability to define the size of the database in the constructorOct 3, 2019
@miripiruni
Copy link

@lovasoa could you pay attention to this change please? This is not just optimization.initialDbSize allows us to merge several tables in a acceptable amount of time. The union is too slow without it.

Thank you!

@lovasoa
Copy link
Member

lovasoa commentedOct 11, 2019
edited
Loading

The structure of this repo makes it very difficult to review changes. I am currently not merging pull requests by lack of time.
I cannot just merge this kind of PR because they contain a lot of minified JS that could contain malicious code.

One thing to do that would make it much easier to make changes is to handle compilation to JS by a continuous integration tool, and maybe use a more popular language such as JS of TypeScript.

@missvalentinep
Copy link
Author

What if I removed the compiled files from pull request and you compiled them yourself or left the compilation to prepublish command?

brody4hire reacted with thumbs up emoji

@miripiruni
Copy link

@lovasoa OK, I totally agree. Internet is dangerous place.

To be sure there are no malware in minified JS: May I ask you to take diff fromsrc/api.coffee only and makedist/* by yourself?

@miripiruni
Copy link

miripiruni commentedOct 11, 2019
edited
Loading

I cannot just merge this kind of PR because they contain a lot of minified JS that could contain malicious code.

The fact iswe also are tremble because it's hard to understand thatdist/* from latest version currently does not contains any suspicious code.

@lovasoa
Copy link
Member

What would both reduce the maintenance burden (which is the biggest problem here) and improve security is having a continuous integration service bundling the files.

@lovasoa
Copy link
Member

@kripken : maybe you can activate GitHub actions for this repo?https://github.com/features/actions

@kripken
Copy link
Collaborator

@lovasoa all I see is a way to request being added to the beta - is there something else? I did that now.

@lovasoa
Copy link
Member

No, nothing else. Once you are added to the beta, we can add a yaml file in.github/workflows with the scripts we want to run.

@kripken
Copy link
Collaborator

I got an email that I am in the beta, so maybe it can work now...

@lovasoa
Copy link
Member

lovasoa commentedOct 16, 2019
edited
Loading

Thank you Alon. I created a github workflow that compiles the code, tests it, and uploads the resulting artifacts:https://github.com/kripken/sql.js/actions

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@missvalentinep@miripiruni@lovasoa@kripken

[8]ページ先頭

©2009-2025 Movatter.jp