- Notifications
You must be signed in to change notification settings - Fork1.1k
add ability to define the size of the database in the constructor#298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
miripiruni commentedOct 11, 2019
@lovasoa could you pay attention to this change please? This is not just optimization. Thank you! |
lovasoa commentedOct 11, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The structure of this repo makes it very difficult to review changes. I am currently not merging pull requests by lack of time. One thing to do that would make it much easier to make changes is to handle compilation to JS by a continuous integration tool, and maybe use a more popular language such as JS of TypeScript. |
missvalentinep commentedOct 11, 2019
What if I removed the compiled files from pull request and you compiled them yourself or left the compilation to prepublish command? |
miripiruni commentedOct 11, 2019
@lovasoa OK, I totally agree. Internet is dangerous place. To be sure there are no malware in minified JS: May I ask you to take diff from |
miripiruni commentedOct 11, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The fact iswe also are tremble because it's hard to understand that |
lovasoa commentedOct 11, 2019
What would both reduce the maintenance burden (which is the biggest problem here) and improve security is having a continuous integration service bundling the files. |
lovasoa commentedOct 13, 2019
@kripken : maybe you can activate GitHub actions for this repo?https://github.com/features/actions |
kripken commentedOct 13, 2019
@lovasoa all I see is a way to request being added to the beta - is there something else? I did that now. |
lovasoa commentedOct 14, 2019
No, nothing else. Once you are added to the beta, we can add a yaml file in |
kripken commentedOct 15, 2019
I got an email that I am in the beta, so maybe it can work now... |
lovasoa commentedOct 16, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you Alon. I created a github workflow that compiles the code, tests it, and uploads the resulting artifacts:https://github.com/kripken/sql.js/actions |
When we have to work with big data, the ability to predefine the size of a new database can significantly speed up script execution time, because multiple calls to MEMF.expandFileStorage is way less efficient than one "bigger" call to it.
JavaScript profile of merging 7 databases (each of size ~15 MB) into one, without expanding the final db file first

The same operation but with expanding the final database to the size of (sum of 7 databases' sizes)
