Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow MAVEN_HOME or M2_HOME for integration tests#235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabapp2 merged 3 commits intospring-projects-experimental:mainfromcab105:test-fixes
Jul 30, 2022

Conversation

@cab105
Copy link
Contributor

The IntegrationTestBaseClass is looking for theMAVEN_HOME environment variable, which only applies for Maven 1.x instead ofM2_HOME which applies to Maven 2.x. This PR adds support for the second environment variable.

@cab105
Copy link
ContributorAuthor

This PR includes an additional fix to ensure the version of spring-boot-starter-parent exists in Maven Central (3.x doesn't according tohttps://mvnrepository.com/artifact/org.springframework.boot/spring-boot-starter-parent)

@cab105
Copy link
ContributorAuthor

That's my take. Okay let me take it out and verify.

fabapp2 reacted with laugh emoji

@cab105cab105 requested a review fromfabapp2July 18, 2022 17:36
@fabapp2fabapp2 changed the titleFix integration testAllow MAVEN_HOME or M2_HOME for integration testsJul 30, 2022
@fabapp2fabapp2 merged commit8bb5d8d intospring-projects-experimental:mainJul 30, 2022
@fabapp2fabapp2 added the type: enhancementNew feature or request labelSep 26, 2022
@fabapp2fabapp2 added this to thev0.12.0 milestoneSep 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@fabapp2fabapp2fabapp2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cab105cab105

Labels

type: enhancementNew feature or request

Projects

None yet

Milestone

v0.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@cab105@fabapp2

[8]ページ先頭

©2009-2025 Movatter.jp