I introduced a new runtime flag for spring-boot-migrator calledsbm.muleTriggerMeshTransformEnabled that will modify the generated mule-to-boot recipe for handling DataWeave transformations to stream the transformation toTriggerMesh's Dataweave Transformer.

The generated code works best when the service runs inside a Kubernetes cluster leveraging Knative's Sink Binding to associate the the newly migrated service to the TriggerMesh Dataweave transformation, however the service can run on it's own by setting theK_SINK environment variable to the exposed transformation service.

I created agist to demonstrate what an integration within TriggerMesh would look like.

fabapp2 added the Mule-3.9 label

Jul 7, 2022

Copy link

Contributor

fabapp2 commentedJul 7, 2022

@cab105 Thank you for your contribution!

I had three comments. Feel free to ping me if you want to discuss in person?

fabapp2 suggested changes

Jul 7, 2022

View reviewed changes

...ava/org/springframework/sbm/mule/actions/javadsl/translators/dwl/DwlTransformTranslator.java OutdatedShow resolvedHide resolved

...ava/org/springframework/sbm/mule/actions/javadsl/translators/dwl/DwlTransformTranslator.javaShow resolvedHide resolved

...ava/org/springframework/sbm/mule/actions/javadsl/translators/dwl/DwlTransformTranslator.java OutdatedShow resolvedHide resolved

Copy link

ContributorAuthor

cab105 commentedJul 7, 2022•
edited
Loading

@cab105 Thank you for your contribution!
I had three comments. Feel free to ping me if you want to discuss in person?

Thank you for taking a look at@fabapp2 . Will address the rest template, tabs, and test issues, then resubmit.

Copy link

Contributor

sanagaraj-pivotal commentedJul 11, 2022

Could we get an integration test for this feature, please referthis test for info

cab105 force-pushed thetm-transformation branch fromf265415 toda0fef5Compare

July 17, 2022 03:10

cab105 force-pushed thetm-transformation branch 2 times, most recently from711359f to78f2ee8Compare

August 7, 2022 22:20

Copy link

Contributor

fabapp2 commentedAug 15, 2022

Hi@cab105

Are you facing issues with this? If you like we can pair to get the last few bits added and this PR merged?

Copy link

ContributorAuthor

cab105 commentedAug 16, 2022

The codebase has been pretty unstable due to the springboot 3 work, but does look like it has now solidified, and am identifying issues with my original test code that need to be addressed. Once that is resolved, then we should be good to go.

cab105 force-pushed thetm-transformation branch froma376ef0 to31c1533Compare

August 25, 2022 02:23

Copy link

ContributorAuthor

cab105 commentedAug 25, 2022

Resync from upstream main branch, added unit tests, and migrated the primary dataweave transformation into a template file.

cab105 force-pushed thetm-transformation branch fromb451850 toacc51b9Compare

September 1, 2022 15:56

Copy link

ContributorAuthor

cab105 commentedSep 6, 2022

So I've been able to resolve some of my outstanding issues, and have fixed a couple of issues in SBM proper (#385 and#373). Given the current Mule integration test that was cited in the comments is disabled due to#351, I'm wondering if there's anything else that would be required for this PR (save for a resync with upstream)?

cab105 force-pushed thetm-transformation branch fromacc51b9 toab033a9Compare

September 6, 2022 20:21

cab105 requested a review fromfabapp2

September 6, 2022 20:22

cab105 force-pushed thetm-transformation branch fromab033a9 tod31c0d3Compare

September 8, 2022 20:50

cab105 force-pushed thetm-transformation branch fromf1fac5d tofa7bf11Compare

September 21, 2022 01:16

cab105 added7 commits

September 20, 2022 18:17

Add initial TriggerMesh transformation support

37d850d

Strip out LinkedMultiValueMap as it is no longer necessary

320e1df

Add triggermesh parameter and clean up mule to boot integration

4a48fa2

Address PR feedback and merge conflicts

622a7cc

Add unit test and migrate transformation class to a template

0f55515

Re-add autowired template configuration and if case to work around un…

3ffb5b5

…it test scenario

Add integration tests

7fa4a62

cab105 force-pushed thetm-transformation branch fromfa7bf11 to7fa4a62Compare

September 21, 2022 01:18

cab105 commented

Sep 21, 2022

View reviewed changes

...hell/src/test/java/org/springframework/sbm/MigrateSimpleMuleAppDataweaveIntegrationTest.java Outdated

		importstaticorg.assertj.core.api.Assertions.assertThat;

		@TestMethodOrder(MethodOrderer.MethodName.class)
		//@Disabled("Temporary disabled before CI will be fixed with docker in docker issue: #351")

Copy link

ContributorAuthor

cab105Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking at the base test, this annotation is in effect, but left it commented out to facilitate verification for review.

Copy link

Contributor

fabapp2Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure if I get you here, but the method order is obsolete as there's only one test and no shared state, or?
You can remove the commented@Disabled, the test is green 🚀

...hell/src/test/java/org/springframework/sbm/MigrateSimpleMuleAppDataweaveIntegrationTest.javaShow resolvedHide resolved

...hell/src/test/java/org/springframework/sbm/MigrateSimpleMuleAppDataweaveIntegrationTest.java

		IntegrationTestBaseClass.beforeAll();

		// Will need to ensure this is set globally for the test
		System.setProperty("sbm.muleTriggerMeshTransformEnabled","true");

Copy link

ContributorAuthor

cab105Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I looked into overriding@SpringProperties, but this would not get picked up by the transformer that would swap out the stub code for the code that will send the transformation out to the TriggerMesh Dataweave transformer. If there's a cleaner way to do this, then would appreciate hearing it.

Copy link

Contributor

fabapp2Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we should rework this approach and set the flag in the action of a dedicated recipe, e.g.migrate-mule-to-boot-tm and then just call it from here.

...ava/org/springframework/sbm/mule/actions/javadsl/translators/dwl/DwlTransformTranslator.java

		Map<Class,MuleComponentToSpringIntegrationDslTranslator>translatorsMap
		) {
		// Ugly hack to work around an inability to inject a sbm property into the mulesoft parser.
		StringisTmTransformationEnabled =System.getProperty("sbm.muleTriggerMeshTransformEnabled");

Copy link

ContributorAuthor

cab105Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Required to work around case when running unit test and@Autowired is unable to bring in the SBM properties.

Copy link

Contributor

fabapp2Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Technically speaking, this should work

@Autowiredprivate SbmApplicationProperties p;public void m() {   p.getPropertyXyz();}

But in this case an annotation on type level@ConditionalOnProperty(name = "sbm.muleTriggerMeshTransformEnabled", havingValue = "true") of a dedicated implementation would would be better.

fabapp2 suggested changes

Sep 21, 2022

View reviewed changes

Copy link

Contributor

fabapp2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@cab105 !
Thanks for your effort! 🚀

I think the hacky ;) bits will disapear as soon as the application property is removed and the action gets parametrized per recipe, which feels somehow naturally (now).
Everything else lgtm!

...-recipes-mule-to-boot/src/main/java/org/springframework/sbm/mule/actions/JavaDSLAction2.javaShow resolvedHide resolved

...-recipes-mule-to-boot/src/main/java/org/springframework/sbm/mule/actions/JavaDSLAction2.java OutdatedShow resolvedHide resolved

...hell/src/test/java/org/springframework/sbm/MigrateSimpleMuleAppDataweaveIntegrationTest.javaShow resolvedHide resolved

...hell/src/test/java/org/springframework/sbm/MigrateSimpleMuleAppDataweaveIntegrationTest.java

		IntegrationTestBaseClass.beforeAll();

		// Will need to ensure this is set globally for the test
		System.setProperty("sbm.muleTriggerMeshTransformEnabled","true");

Copy link

Contributor

fabapp2Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we should rework this approach and set the flag in the action of a dedicated recipe, e.g.migrate-mule-to-boot-tm and then just call it from here.

...s/sbm-recipes-mule-to-boot/src/main/java/org/springframework/sbm/mule/MigrateMuleToBoot.java

		Stringdescription ="Migrate Mulesoft 3.9 to Spring Boot.";

		// Flag to enable TriggerMesh ransformation mode
		if (sbmProperties.isMuleTriggerMeshTransformEnabled()) {

Copy link

Contributor

fabapp2Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should better create two bean methods here, calling one factory method that creates the recipe twice with the flag true and false. Taht would then finally allow to remove the application property :)

removed flag set to default, formatted test data

5df5d14

fabapp2 reviewed

Sep 21, 2022

View reviewed changes

Copy link

Contributor

fabapp2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just realize that there must be some way to toggle these translators if boot creates them...
but it should not be an application/system property when possible...
it should come from the recipe/action...
this could be tricky...

...ava/org/springframework/sbm/mule/actions/javadsl/translators/dwl/DwlTransformTranslator.java

		Map<Class,MuleComponentToSpringIntegrationDslTranslator>translatorsMap
		) {
		// Ugly hack to work around an inability to inject a sbm property into the mulesoft parser.
		StringisTmTransformationEnabled =System.getProperty("sbm.muleTriggerMeshTransformEnabled");

Copy link

Contributor

fabapp2Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Technically speaking, this should work

@Autowiredprivate SbmApplicationProperties p;public void m() {   p.getPropertyXyz();}

But in this case an annotation on type level@ConditionalOnProperty(name = "sbm.muleTriggerMeshTransformEnabled", havingValue = "true") of a dedicated implementation would would be better.

Copy link

ContributorAuthor

cab105 commentedSep 21, 2022

I just realize that there must be some way to toggle these translators if boot creates them...
but it should not be an application/system property when possible...
it should come from the recipe/action...
this could be tricky...

It is. I originally used your approach of@Autowired onSbmApplicationProperties, but the unit test doesn't wire in theSbmApplicationProperties resulting in the tests to use the default behavior, and why I explicitly checked/set the System properties where I did. Granted if there was an easier way to pass a flag through the rewrite engine, then I'd be happy, but it appeared to require a lot more refactoring than I felt comfortable to pass the single flag down to the DwlTransformTranslator class.

Copy link

Contributor

fabapp2 commentedSep 22, 2022

I just realize that there must be some way to toggle these translators if boot creates them...
but it should not be an application/system property when possible...
it should come from the recipe/action...
this could be tricky...
It is. I originally used your approach of@Autowired onSbmApplicationProperties, but the unit test doesn't wire in theSbmApplicationProperties resulting in the tests to use the default behavior, and why I explicitly checked/set the System properties where I did. Granted if there was an easier way to pass a flag through the rewrite engine, then I'd be happy, but it appeared to require a lot more refactoring than I felt comfortable to pass the single flag down to the DwlTransformTranslator class.

The problem is that the test is not a@SpringBootTest and theSbmApplicationProperties would need to be added to theTestProjectContext test harness. But due to the inheritance design it is not (yet) possible.

What about...
you leave the property as it is, for now, fix the few comments left and we finally merge this back in?
And I will think about a way to remove the need for the application property.
Not 💯 sure yet how this will look like though...

Address PR comments

750d3d3

fabapp2 approved these changes

Sep 23, 2022

View reviewed changes

Merge branch 'main' into tm-transformation

15141be

fabapp2 added the type: enhancementNew feature or request label

Sep 23, 2022

fabapp2 assignedcab105

Sep 23, 2022

fabapp2 added this to thev0.12.0 milestone

Sep 23, 2022

fabapp2 linked an issue

Sep 23, 2022

that may beclosed by this pull request

Supports TriggerMesh for MuleSoft Dataweave Transformations#434

Closed

Merge branch 'main' into tm-transformation

b1fc898

fabapp2 merged commitcaab9e0 intospring-projects-experimental:main

Sep 23, 2022

cab105 deleted the tm-transformation branch

September 23, 2022 18:43

Labels

type: enhancement

New feature or request

Movatterモバイル変換

Add support for generating code to send MuleSoft Dataweave Transformations to TriggerMesh#183

Add support for generating code to send MuleSoft Dataweave Transformations to TriggerMesh#183

Uh oh!

Conversation

cab105 commentedJun 30, 2022

Uh oh!

fabapp2 commentedJul 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cab105 commentedJul 7, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

sanagaraj-pivotal commentedJul 11, 2022

Uh oh!

fabapp2 commentedAug 15, 2022

Uh oh!

cab105 commentedAug 16, 2022

Uh oh!

cab105 commentedAug 25, 2022

Uh oh!

cab105 commentedSep 6, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabapp2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabapp2 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cab105 commentedSep 21, 2022

Uh oh!

fabapp2 commentedSep 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cab105 commentedJul 7, 2022•
edited
Loading