- Notifications
You must be signed in to change notification settings - Fork248
remove distutils in order to support python 3.12#2439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| defstrtobool(val:str)->bool: | ||
| returnval.lower()in ("yes","y","true","t","1") | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hello@vebjorre , thanks very much for this contribution! We'd like to request two small edits after which we'd be happy to merge and release this.
- It looks like
"on"should be in the tuple - The original
strtoboolimplementation throws a ValueError if you pass in an invalid value, we'd like to keep that behavior
If you could make those edits then we'll move this forward, thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you, that's perfect!
I'm seeing a failure in our CI, I think it's probably spurious but I'll have to investigate that before we can merge. I'll investigate next week and update you.
…values to include "on"/"off" variants.
Uh oh!
There was an error while loading.Please reload this page.
Finishing the work of@akx in#2144, removing any use of distutils in order to support python>=3.12.
Fixes#2091