Commitb47efb2

committed

[fix] Remove any reference to theglobal variable

1 parentd95e38f commitb47efb2Copy full SHA for b47efb2

File tree

+19

-20

lines changed

+19

-20

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,8 @@`
`7`	`7`	`varisArray=require('isarray');`
`8`	`8`	`varisBuf=require('./is-buffer');`
`9`	`9`	`vartoString=Object.prototype.toString;`
`10`		`-varwithNativeBlob=typeofglobal.Blob==='function'\|\|toString.call(global.Blob)==='[object BlobConstructor]';`
`11`		`-varwithNativeFile=typeofglobal.File==='function'\|\|toString.call(global.File)==='[object FileConstructor]';`
	`10`	`+varwithNativeBlob=typeofBlob==='function'\|\|(typeofBlob!=='undefined'&&toString.call(Blob)==='[object BlobConstructor]');`
	`11`	`+varwithNativeFile=typeofFile==='function'\|\|(typeofFile!=='undefined'&&toString.call(File)==='[object FileConstructor]');`
`12`	`12`
`13`	`13`	`/**`
`14`	`14`	`* Replaces every Buffer \| ArrayBuffer in packet with a numbered placeholder.`

Lines changed: 7 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,16 +1,12 @@`
`1`	`1`
`2`	`2`	`module.exports=isBuf;`
`3`	`3`
`4`		`-varwithNativeBuffer=typeofglobal.Buffer==='function'&&typeofglobal.Buffer.isBuffer==='function';`
`5`		`-varwithNativeArrayBuffer=typeofglobal.ArrayBuffer==='function';`
	`4`	`+varwithNativeBuffer=typeofBuffer==='function'&&typeofBuffer.isBuffer==='function';`
	`5`	`+varwithNativeArrayBuffer=typeofArrayBuffer==='function';`
`6`	`6`
`7`		`-varisView=(function(){`
`8`		`-if(withNativeArrayBuffer&&typeofglobal.ArrayBuffer.isView==='function'){`
`9`		`-returnglobal.ArrayBuffer.isView;`
`10`		`-}else{`
`11`		`-returnfunction(obj){returnobj.bufferinstanceofglobal.ArrayBuffer;};`
`12`		`-}`
`13`		`-})();`
	`7`	`+varisView=function(obj){`
	`8`	`+returntypeofArrayBuffer.isView==='function' ?ArrayBuffer.isView(obj) :(obj.bufferinstanceofArrayBuffer);`
	`9`	`+};`
`14`	`10`
`15`	`11`	`/**`
`16`	`12`	`* Returns true if obj is a buffer or an arraybuffer.`
`@@ -19,6 +15,6 @@ var isView = (function () {`
`19`	`15`	`*/`
`20`	`16`
`21`	`17`	`functionisBuf(obj){`
`22`		`-return(withNativeBuffer&&global.Buffer.isBuffer(obj))\|\|`
`23`		`-(withNativeArrayBuffer&&(objinstanceofglobal.ArrayBuffer\|\|isView(obj)));`
	`18`	`+return(withNativeBuffer&&Buffer.isBuffer(obj))\|\|`
	`19`	`+(withNativeArrayBuffer&&(objinstanceofArrayBuffer\|\|isView(obj)));`
`24`	`20`	`}`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,10 @@`
`1`	`1`	`varparser=require('../index.js');`
`2`		`-varexpect=require('expect.js');`
`3`	`2`	`varhelpers=require('./helpers.js');`
`4`		`-varencode=parser.encode;`
`5`		`-vardecode=parser.decode;`
`6`	`3`
`7`		`-varBlobBuilder=global.BlobBuilder\|\|global.WebKitBlobBuilder\|\|global.MSBlobBuilder\|\|global.MozBlobBuilder;`
	`4`	`+varBlobBuilder=typeofBlobBuilder!=='undefined' ?BlobBuilder :`
	`5`	`+typeofWebKitBlobBuilder!=='undefined' ?WebKitBlobBuilder :`
	`6`	`+typeofMSBlobBuilder!=='undefined' ?MSBlobBuilder :`
	`7`	`+typeofMozBlobBuilder!=='undefined' ?MozBlobBuilder :false;`
`8`	`8`
`9`	`9`	`describe('parser',function(){`
`10`	`10`	`it('encodes a Blob',function(){`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,10 @@ var blobSupported = (function() {`
`12`	`12`	`* Create a blob builder even when vendor prefixes exist`
`13`	`13`	`*/`
`14`	`14`
`15`		`-varBlobBuilder=global.BlobBuilder\|\|global.WebKitBlobBuilder\|\|global.MSBlobBuilder\|\|global.MozBlobBuilder;`
	`15`	`+varBlobBuilder=typeofBlobBuilder!=='undefined' ?BlobBuilder :`
	`16`	`+typeofWebKitBlobBuilder!=='undefined' ?WebKitBlobBuilder :`
	`17`	`+typeofMSBlobBuilder!=='undefined' ?MSBlobBuilder :`
	`18`	`+typeofMozBlobBuilder!=='undefined' ?MozBlobBuilder :false;`
`16`	`19`	`varblobBuilderSupported=!!BlobBuilder&&!!BlobBuilder.prototype.append&&!!BlobBuilder.prototype.getBlob;`
`17`	`20`
`18`	`21`	`require('./parser.js');`
`@@ -21,7 +24,7 @@ if (!env.browser) {`
`21`	`24`	`require('./buffer.js');`
`22`	`25`	`}`
`23`	`26`
`24`		`-if(global.ArrayBuffer){`
	`27`	`+if(typeofArrayBuffer!=='undefined'){`
`25`	`28`	`require('./arraybuffer.js');`
`26`	`29`	`}`
`27`	`30`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,4 +2,4 @@`
`2`	`2`	`// we only do this in our tests because we need to test engine.io-client`
`3`	`3`	`// support in browsers and in node.js`
`4`	`4`	`// some tests do not yet work in both`
`5`		`-module.exports.browser=!!global.window;`
	`5`	`+module.exports.browser=typeofwindow!=='undefined';`

Comments

(0)