- Notifications
You must be signed in to change notification settings - Fork20
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:socketio/socket.io-deno
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:0.1.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:socketio/socket.io-deno
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:0.1.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 7commits
- 12files changed
- 1contributor
Commits on Sep 13, 2022
- darrachequesne committed
Sep 13, 2022 fix: disallow mismatching transport
This was caught thanks to the test suite there: [1]Rule: ignores HTTP requests with same sid after upgrade[1]:https://github.com/socketio/engine.io-protocol/blob/main/test-suite/test-suite.js
darrachequesne committedSep 13, 2022 fix: disallow duplicate WebSocket connections with same sid
This was caught thanks to the test suite there: [1]Rule: ignores WebSocket connection with same sid after upgrade[1]:https://github.com/socketio/engine.io-protocol/blob/main/test-suite/test-suite.js
darrachequesne committedSep 13, 2022 fix: prevent crash when using custom headers
It seems that the Deno.upgradeWebSocket() method does not allow toprovide additional headers during the WebSocket handshake.Exception:> TypeError: Headers are immutable.> at Headers.set (deno:ext/fetch/20_headers.js:384:15)> at /packages/engine.io/lib/transports/websocket.ts:60:24> at Headers.forEach (deno:ext/webidl/00_webidl.js:1001:13)> at WS.onRequest (/packages/engine.io/lib/transports/websocket.ts:59:21)> at Server.handshake (/packages/engine.io/lib/server.ts:344:31)
darrachequesne committedSep 13, 2022 fix: send a "noop" packet when transport is already closed
This was caught thanks to the test suite there: [1]Rule: close > HTTP long-polling > forcefully closes the session[1]:https://github.com/socketio/engine.io-protocol/blob/main/test-suite/test-suite.js
darrachequesne committedSep 13, 2022
Commits on Sep 14, 2022
refactor: use lowercase response with HTTP long-polling
In order to match the behavior of the Node.js implementation.Reference:https://github.com/socketio/engine.io/blob/917d1d29e13f2e8f523c3738f6413f67b587aebe/lib/transports/polling.ts#L174
darrachequesne committedSep 14, 2022
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff 0.1.0...0.1.1
Uh oh!
There was an error while loading.Please reload this page.