- Notifications
You must be signed in to change notification settings - Fork10.1k
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:socketio/socket.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:4.5.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:socketio/socket.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:4.5.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 7commits
- 30files changed
- 3contributors
Commits on May 25, 2022
fix: prevent the socket from joining a room after disconnection
Calling `socket.join()` after disconnection would lead to a memoryleak, because the room was never removed from the memory:```jsio.on("connection", (socket) => { socket.disconnect(); socket.join("room1"); // leak});```Related:-#4067-#4380darrachequesne committedMay 25, 2022
Commits on Jun 27, 2022
Production:- socket.io-parser: ~4.0.4 => ~4.2.0Development:- superagent: ^6.1.0 => ^8.0.0- tsd: ^0.17.0 => ^0.21.0Related:#3709
darrachequesne committedJun 27, 2022
Commits on Sep 1, 2022
refactor: add missing constraints (#4431)
See also:microsoft/TypeScript#49489
DanielRosenwasser authoredSep 1, 2022
Commits on Sep 2, 2022
fix(uws): prevent the server from crashing after upgrade
This should fix a rare case where the Engine.IO connection was upgradedto WebSocket while the Socket.IO socket was disconnected, which wouldresult in the following exception:> TypeError: Cannot read properties of undefined (reading 'forEach')> at subscribe (/node_modules/socket.io/dist/uws.js:87:11)> at Socket.<anonymous> (/node_modules/socket.io/dist/uws.js:28:17)> at Socket.emit (node:events:402:35)> at WebSocket.onPacket (/node_modules/engine.io/build/socket.js:214:22)> at WebSocket.emit (node:events:390:28)> at WebSocket.onPacket (/node_modules/engine.io/build/transport.js:92:14)> at WebSocket.onData (/node_modules/engine.io/build/transport.js:101:14)> at message (/node_modules/engine.io/build/userver.js:56:30)Related:#4443
darrachequesne committedSep 2, 2022
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff 4.5.1...4.5.2
Uh oh!
There was an error while loading.Please reload this page.