- Notifications
You must be signed in to change notification settings - Fork81
CanInterface: add set_can_params method to set multiple parameters#66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This new method allows to set multiple CAN-specific parameters at onceinstead of over multiple netlink messages.This is also required for some more obscure devices which might notaccept some parameter configurations split over multiple netlinkmessages.
This does seem like a good idea - to be able to set multiple parameters in a single call. But I'm wondering about maintaining another data structure so similar to But if we do go with what you suggest - a separate struct of all optional, settable parameters,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll merge the data struct with the existingInterfaceCanParams
, but otherwise looking good.
I wonder what happened here,@fpagliughi. You say in above comment, you merge with the existing |
The |
This new method allows to set multiple CAN-specific parameters at once instead of over multiple netlink messages.
This is also required for some more obscure devices which might not accept some parameter configurations split over multiple netlink messages.