NotificationsYou must be signed in to change notification settings
Fork81
Star173

Dump parsing also optionally trims off CR at the line end#65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fpagliughi merged 2 commits intosocketcan-rs:masterfromopenstarnz:master

Jun 9, 2024

Merged

Dump parsing also optionally trims off CR at the line end#65

fpagliughi merged 2 commits intosocketcan-rs:masterfromopenstarnz:master

Jun 9, 2024

Conversation

Copy link

pietgeursen commentedApr 10, 2024

Would you be open to merging this?

I haven't looked intowhy my candump has a \r\n rather than just a \n at the line ending but it does.

Piet Geursen added2 commits

April 11, 2024 09:22

dump parsing also trims CR

d2ee7f0

Merge branch 'master' of github.com:socketcan-rs/socketcan-rs

77434a2

Copy link

Collaborator

fpagliughi commentedApr 12, 2024

Did the dump come off a Windows machine somehow?

Copy link

Author

pietgeursen commentedApr 16, 2024

No, it's running on a beaglebone black running debian.

Copy link

Collaborator

fpagliughi commentedApr 18, 2024•
edited
Loading

OK. That is weird then. I was curious where it might be coming from. But your addition looks harmless enough. I will try it out and merge when I have a minute.

I haven't personally used or touched the code to parse the dump file, but it does look like it could stand to be updated. Seems like it could be simplified using a regex to parse.