Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CanFdSocket read_frame crash fix#61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

pwnorbitals
Copy link

Reading a standard CAN frame through theCanFdSocket leads to a crash due to mismatching sizes in the frame construction’scopy_from_slice. Thix fix has been tested and builds valid CAN frames.

@pd0wm
Copy link

DoesCanFdSocket::read_raw_frame need the same fix?https://github.com/socketcan-rs/socketcan-rs/blob/master/src/socket.rs#L617

@pwnorbitals
Copy link
Author

DoesCanFdSocket::read_raw_frame need the same fix?https://github.com/socketcan-rs/socketcan-rs/blob/master/src/socket.rs#L617

I think so. Fixed it too

@fpagliughi
Copy link
Collaborator

Oof. Sorry, my bad. I was hacking on this update before I got an FD controller.

Copy link
Collaborator

@fpagliughifpagliughi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@fpagliughifpagliughi merged commit12e8476 intosocketcan-rs:masterJun 9, 2024
TimosAmpel added a commit to virtualopensystems/vhost-device that referenced this pull requestNov 11, 2024
Update socketcan-rs to v3.3.1 which solve the issue regarding the CANFD messages:-socketcan-rs/socketcan-rs#61Signed-off-by: Timos Ampelikiotis <t.ampelikiotis@virtualopensystems.com>
TimosAmpel added a commit to virtualopensystems/vhost-device that referenced this pull requestNov 11, 2024
Update socketcan-rs to v3.3.1 which solve the issue regarding the CANFD messages:-socketcan-rs/socketcan-rs#61Signed-off-by: Timos Ampelikiotis <t.ampelikiotis@virtualopensystems.com>
TimosAmpel added a commit to virtualopensystems/vhost-device that referenced this pull requestNov 12, 2024
Changes:- Update socketcan-rs to v3.3.1 which solve the issue regarding the CANFD messages:  -socketcan-rs/socketcan-rs#61- Update Cargo.lock files under main and staging workspaceSigned-off-by: Timos Ampelikiotis <t.ampelikiotis@virtualopensystems.com>
epilys pushed a commit to rust-vmm/vhost-device that referenced this pull requestNov 14, 2024
Changes:- Update socketcan-rs to v3.3.1 which solve the issue regarding the CANFD messages:  -socketcan-rs/socketcan-rs#61- Update Cargo.lock files under main and staging workspaceSigned-off-by: Timos Ampelikiotis <t.ampelikiotis@virtualopensystems.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpagliughifpagliughifpagliughi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@pwnorbitals@pd0wm@fpagliughi@gama-ci
[8]ページ先頭
©2009-2025 Movatter.jp