- Notifications
You must be signed in to change notification settings - Fork81
Dump: handle extended IDs#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c75952d
to34ec92b
CompareSet extended flag if ID is exceeding 11 bitsDSigned-off-by: Michał Chodzikiewicz <mchodzikiewicz@gmail.com>
34ec92b
to5643c89
Comparehey, I'd be very grateful for any feedback - I use this crate but I need extended ID working and I don't feel like maintaining my own fork 😅 |
Apologies, this is a big holiday week in the US, and last week was the crush of work everyone was trying to get done before the big holiday week. So I haven't had time for any open-source stuff. But if the PR test out OK, I'll merge it. And if it doesn't, I'll ask you to fix it, then merge it. :-) But, yes, dump should support extended ID's. |
Great to hear, sure thingo :) Sorry for rushing, I was just a tiny bit afraid that no one hangs here anymore |
XVilka commentedAug 7, 2023
Would be nice to have this merged, it's quite basic feature, IMHO. |
@fpagliughi any updates? |
Apologies. I’ve been away on holiday much of the summer. I’ll be returning early Sept and getting back to some open source work shortly after. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Set extended flag if ID is exceeding 11 bits