Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Dump: handle extended IDs#45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mchodzikiewicz
Copy link
Contributor

Set extended flag if ID is exceeding 11 bits

@mchodzikiewiczmchodzikiewiczforce-pushed thefix/extended-id branch 2 times, most recently fromc75952d to34ec92bCompareJune 28, 2023 20:06
Set extended flag if ID is exceeding 11 bitsDSigned-off-by: Michał Chodzikiewicz <mchodzikiewicz@gmail.com>
@mchodzikiewicz
Copy link
ContributorAuthor

hey, I'd be very grateful for any feedback - I use this crate but I need extended ID working and I don't feel like maintaining my own fork 😅

@fpagliughi
Copy link
Collaborator

Apologies, this is a big holiday week in the US, and last week was the crush of work everyone was trying to get done before the big holiday week. So I haven't had time for any open-source stuff. But if the PR test out OK, I'll merge it. And if it doesn't, I'll ask you to fix it, then merge it. :-)

But, yes, dump should support extended ID's.

@mchodzikiewicz
Copy link
ContributorAuthor

Great to hear, sure thingo :) Sorry for rushing, I was just a tiny bit afraid that no one hangs here anymore

@XVilka
Copy link

Would be nice to have this merged, it's quite basic feature, IMHO.

mchodzikiewicz reacted with thumbs up emoji

@mchodzikiewicz
Copy link
ContributorAuthor

@fpagliughi any updates?

@fpagliughi
Copy link
Collaborator

Apologies. I’ve been away on holiday much of the summer. I’ll be returning early Sept and getting back to some open source work shortly after.

mchodzikiewicz and Kampouse reacted with thumbs up emoji

Copy link
Collaborator

@fpagliughifpagliughi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@fpagliughifpagliughi merged commitd1967e7 intosocketcan-rs:masterSep 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpagliughifpagliughifpagliughi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mchodzikiewicz@fpagliughi@XVilka

[8]ページ先頭

©2009-2025 Movatter.jp