- Notifications
You must be signed in to change notification settings - Fork81
implement AsPtr for CanAnyFrame#43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
1efb834
to6261346
CompareCI failure is not related to PR, see#44 (and merge that one first, will rebase this one onto the other PR) |
6261346
to7cdc0a6
CompareThanks for the PR! I just quickly pushed out a pair of releases and totally forgot to look at the PR's. I'll get these in an do another release ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Hi! This fixes the somewhat comical issue that I cannot directly put a
CanAnyFrame
back into aCanFdSocket
from which I have received it. Bit ugly with thec_void
and making thesize
function non-static, but the smallest possible increment within the current implementation..