NotificationsYou must be signed in to change notification settings
Fork81
Star173

Exchange custom netlink fork for neli crate#13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

marcelbuesing wants to merge2 commits intosocketcan-rs:masterfrommarcelbuesing:neli

Closed

Exchange custom netlink fork for neli crate#13

marcelbuesing wants to merge2 commits intosocketcan-rs:masterfrommarcelbuesing:neli

Conversation

Copy link

Contributor

marcelbuesing commentedNov 21, 2019

This removes the custom netlink dependency in exchange for theneli-crate. I have testedbring_up andbring_down and it seems to work. There is a minor difference in the send that I have not figured out yet why sa_family is not added in neli or if that is even relevant since it has the intended effect.

strace -s 100 -f -x of

let iface =CanInterface::open("vcan0").expect("Failed to lookup vcan0 iface");    iface.bring_down().unwrap();

netlink-rs fork:

bind(3, {sa_family=AF_NETLINK, nl_pid=29418, nl_groups=00000000}, 16) = 0sendto(3, {{len=32, type=RTM_NEWLINK, flags=NLM_F_REQUEST|NLM_F_ACK, seq=0, pid=0}, {ifi_family=AF_UNSPEC, ifi_type=ARPHRD_NETROM, ifi_index=if_nametoindex("vcan0"), ifi_flags=0, ifi_change=0x1}}, 32, 0, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 16) = 302recvfrom(3, {{len=36, type=NLMSG_ERROR, flags=NLM_F_CAPPED, seq=0, pid=29418}, {error=0, msg={len=32, type=RTM_NEWLINK, flags=NLM_F_REQUEST|NLM_F_ACK, seq=0, pid=0}}}, 4096, 0, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, [16->12]) = 36

neli:

bind(3, {sa_family=AF_NETLINK, nl_pid=960, nl_groups=00000000}, 12) = 0sendto(3, {{len=32, type=RTM_NEWLINK, flags=NLM_F_REQUEST|NLM_F_ACK, seq=0, pid=0}, {ifi_family=AF_UNSPEC, ifi_type=ARPHRD_NETROM, ifi_index=if_nametoindex("vcan0"), ifi_flags=0, ifi_change=0x1}}, 32, 0, NULL, 0) = 32recvfrom(3, {{len=36, type=NLMSG_ERROR, flags=NLM_F_CAPPED, seq=0, pid=960}, {error=0, msg={len=32, type=RTM_NEWLINK, flags=NLM_F_REQUEST|NLM_F_ACK, seq=0, pid=0}}}, 32768, 0, NULL, NULL) = 36

WIP: since this is still waiting for merge of:jbaublitz/neli#61, I will exchange the git link for a version once that is released.

Exchange custom netlink fork for neli crate

c027490

marcelbuesing force-pushed theneli branch from8f3e48f toc027490Compare

November 21, 2019 16:20

marcelbuesing mentioned this pull request

Nov 21, 2019

Extend RtAddrFamily and allow changing change maskjbaublitz/neli#61

Closed

Update neli to 0.5.0-rc1

678d174

marcelbuesing changed the title~~[WIP] Exchange custom netlink fork for neli crate~~Exchange custom netlink fork for neli crate

Jul 22, 2020

fpagliughi added a commit to fpagliughi/socketcan-rs that referenced this pull request

Feb 21, 2021

Merged PRsocketcan-rs#13to switch to neli crate. Updated to Rust 20…

9138a66

…18 and latest dependencies. Errors now conforming to std::error::Error.

Copy link

Collaborator

fpagliughi commentedFeb 21, 2021

I merged this into my fork at:
https://github.com/fpagliughi/socketcan-rs/tree/develop

There were a number of breaking changes inneli since this PR was done, but I fixed those up and hit a serialization error:
jbaublitz/neli#136

But now that's all working. I still need to re-implement the wait-for-ack functionality which changed in the library, but overallneli does look like a better choice for dealing with the Netlink stuff.

Copy link

ContributorAuthor

marcelbuesing commentedMar 22, 2021

I merged this into my fork at:
https://github.com/fpagliughi/socketcan-rs/tree/develop
There were a number of breaking changes inneli since this PR was done, but I fixed those up and hit a serialization error:
jbaublitz/neli#136
But now that's all working. I still need to re-implement the wait-for-ack functionality which changed in the library, but overallneli does look like a better choice for dealing with the Netlink stuff.

I think neli 0.5.3 that was released yesterday should contain the fix?