This repository was archived by the owner on Dec 5, 2021. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork379
Fix issue with leaving session in a invalid state if GetFile throws an exception after reconnecting to another DC#548
Open
MichaelManley wants to merge1 commit intosochix:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…econnect to original DC even if there is an exception
@sochix can you review? |
andreysolovyov left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tried to apply this fix, but get same result. After first uncatched exception session corrupted and every request ends with "can't read packet" exception. Do we need to make some migration calls after restoring session in final section?
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TelegramClient.GetFile, if the file is in another DC, it reconnects to the DC to be able to get the file. In an exception is thrown after that whilst trying to download the file it doesn't reconnect to the original DC which leaves the session in an invalid state.
This wraps the calls after the ReconnectToDCAs in a try finally to ensure that whatever happens we always try to do the reconnect to the original DC.