- Notifications
You must be signed in to change notification settings - Fork19
feat: biometrics type#15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
kierancrown commentedAug 24, 2024
@akul-smallcase Wondering if this can be merged in? |
zabojad commentedOct 24, 2024
| if (pm.hasSystemFeature(PackageManager.FEATURE_FINGERPRINT)) { | ||
| promise.resolve("Fingerprint"); | ||
| }elseif (pm.hasSystemFeature(PackageManager.FEATURE_FACE)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can you add some references to docs explaining how this works?
does this handles cases where the system has both features but the user has only enabled one of them?
LonelyCpp commentedNov 17, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hey@kierancrown, sorry for the delayed response here - I don't get much time to look at PRs here. I've added a comment on the android implementation, would be great if you can answer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
question: did you mean to commit these changes?
This change adds biometrics type. So you can differentiate between FaceID and TouchID on iOS and Fingerprint and Face unlock on Android.
Tested on iPhone 15 PM and Google Pixel 8