Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow PHPUnit 10, 11 and 12#3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
akrabat merged 15 commits intoslimphp:4.xfromwilliamdes:phpunit-upgrades
Sep 23, 2025
Merged

Conversation

@williamdes
Copy link
Contributor

No backwards incompatible changes

@akrabat
Copy link
Member

Changes look good. Need to sort out the config though.

@williamdes
Copy link
ContributorAuthor

Changes look good. Need to sort out the config though.

Thanks, it's a bit unexpected
I will process it today

@williamdes
Copy link
ContributorAuthor

williamdes commentedSep 20, 2025
edited
Loading

@akrabat I improved the GitHub actions workflow, all does pass on my fork

That said there is something wrong in the code somewhere.
One out of x times this test fails

1) Slim\Tests\Factory\AppFactoryTest::testCreateAppWithEmptyContainerRuntimeException: Could not detect any PSR-17 ResponseFactory implementations. Please install a supported implementation in order to use `AppFactory::create()`. See https://github.com/slimphp/Slim/blob/4.x/README.md for a list of supported implementations./home/runner/work/Slim/Slim/Slim/Factory/AppFactory.php:152/home/runner/work/Slim/Slim/Slim/Factory/AppFactory.php:84/home/runner/work/Slim/Slim/tests/Factory/AppFactoryTest.php:397

Edit: For example on the merge:https://github.com/slimphp/Slim/actions/runs/17945163370/job/51029735524

PS: bonus, I fixed gitattributes for new added dev stuff

akrabat reacted with thumbs up emoji

@coveralls
Copy link

Coverage Status

coverage: 99.608% (+0.09%) from 99.523%
when pullingd2a9975 on williamdes:phpunit-upgrades
into17eba51 on slimphp:4.x.

williamdes reacted with rocket emoji

@akrabatakrabat merged commit18d0fe0 intoslimphp:4.xSep 23, 2025
9 checks passed
@williamdeswilliamdes deleted the phpunit-upgrades branchSeptember 23, 2025 11:48
@akrabat
Copy link
Member

That said there is something wrong in the code somewhere. One out of x times this test fails

1) Slim\Tests\Factory\AppFactoryTest::testCreateAppWithEmptyContainerRuntimeException: Could not detect any PSR-17 ResponseFactory implementations. Please install a supported implementation in order to use `AppFactory::create()`. See https://github.com/slimphp/Slim/blob/4.x/README.md for a list of supported implementations./home/runner/work/Slim/Slim/Slim/Factory/AppFactory.php:152/home/runner/work/Slim/Slim/Slim/Factory/AppFactory.php:84/home/runner/work/Slim/Slim/tests/Factory/AppFactoryTest.php:397

Edit: For example on the merge:https://github.com/slimphp/Slim/actions/runs/17945163370/job/51029735524

That's really weird as the composer step shows that the Nyholm PSR7 implementation had been installed.

williamdes reacted with thumbs up emoji

@williamdes
Copy link
ContributorAuthor

Yes and locally when you re run phpunit it may go green

@akrabatakrabat added this to the4.15.1 milestoneNov 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@akrabatakrabatakrabat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.15.1

Development

Successfully merging this pull request may close these issues.

3 participants

@williamdes@akrabat@coveralls

[8]ページ先頭

©2009-2025 Movatter.jp