- Notifications
You must be signed in to change notification settings - Fork1k
Added an option for ClipboardPaste button to disable ClipboardMonitor#2427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
EchoEllet commentedJan 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for your contribution.
A breaking change is not only the kind that requires users to update their code to compile, but to also keep the current state without any behavior breaking. Changing the default of a value is also a breaking change. What would happen if the user pressed the paste button and there was nothing to paste? I suggest providing the option to override the I'm with the idea of disabling something that's causing issues. However, users should have the option to revert to the old behavior in case they still want |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
singerdmx commentedJan 9, 2025
@EchoEllet can we merge this? |
EchoEllet commentedJan 9, 2025
This is still a breaking change.
This option should be only in the button config, not the toolbar config.
I will work on it soon. However, it's not a high-priorty issue given that I have disabled the buttons by default (revert to the default behavior). |
This comment was marked as resolved.
This comment was marked as resolved.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
* feat!: add config class for clipboard action buttons* docs: update CHANGELOG and migration guide* chore: add a TODO for#2427
Uh oh!
There was an error while loading.Please reload this page.
EchoEllet commentedJan 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Could you confirm if you have rebased your branch? $ git remote add upstream git@github.com:singerdmx/flutter-quill.git$ git fetch upstream$ git rebase upstream/master# Fix conflicts if any. Follow the git CLI instructions.$ git push --force# Force push if conflicts were solved or didn't occur. |
This comment was marked as resolved.
This comment was marked as resolved.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
…ates that this is only applicable for the paste button
This reverts commitdfeb9c2.
Maksim-Nikolaev commentedJan 19, 2025
Rebased again.
Added const to QuillToolbarClipboardButton constructor. |
bfbbfc0 intosingerdmx:masterUh oh!
There was an error while loading.Please reload this page.
EchoEllet commentedJan 21, 2025
Thank you for your patience and contributions, please consider creating issues or reaching out before working on new changes. Have a good day! |
…ingerdmx#2427)---------Co-authored-by: Ellet <echo.ellet@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Description
According to the issue#2421 ClipboardMonitor was causing lag if "paste" button was enabled in QuillSimpleToolbar.
That was because of the periodic 1 second check for Clipboard content. In case with large strings or images in clipboard, it would lag out the application and slow down everything drastically.
This is not a breaking change, however it will change the behavior of availability for "paste" button for QuillSimpleToolbar since it always be enabled (except of readonly mode).
Related Issues
Type of Change