- Notifications
You must be signed in to change notification settings - Fork34
Support SPECIES_128#41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
piotrrzysko commentedMar 3, 2024
Thanks for the contribution! I'm a bit busy right now, working on a feature for the parser that I'll hopefully finish this month, so I can't promise when I'll be able to look at your PR, but I'll definitely do so. I believe that the most important thing is to make sure that this change doesn't affect the most common cases (256-bit and 512-bit registers). |
piotrrzysko commentedApr 30, 2024
I've run the benchmarks on a machine with Neoverse-N1 CPU: and the results are indeed unsatisfactory: I'd like to understand where the disparity between 256/512-bit and 128-bit vectors comes from (see results in README for Intel CPUs). Currently, I don't have space to investigate this. Would you like to do it, or would you like me to come back to it when I have time? |
Squiry commentedMay 2, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The way I've implement that feature for 128bit is not the same as the arm64 implementation in original repo. They take a little bit different approach there, but I don't think we need that kind of details here anyway. |
piotrrzysko commentedMay 5, 2024
I think your code looks good. By |
Squiry commentedMay 5, 2024
That's interesting. My MacBook with m1max gives me different result: It's still bad, but not even close that bad. |
lschanchlane commentedApr 16, 2025
mac m2 i see an issue in parsing json, the error is Unsupported vector species: Species[byte,16,S_128_BIT] |
bluuewhale commentedSep 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
We’re seeing init failures on AWS Graviton4 (128-bit species). On AWS Graviton4, initializing simdjson-java fails at startup with: Anyway, thank you for great work! |
Should help with#9, the performance is still kind of low though (half of what jsoniter shows)