Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] binary bloat analysis#1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
pauldreik wants to merge2 commits intosimdjson:master
base:master
Choose a base branch
Loading
frompauldreik:pauldreik/bloaty

Conversation

@pauldreik
Copy link
Member

@pauldreikpauldreik commentedOct 10, 2020
edited
Loading

This is for measuring binary size. Not that anyone asked about it that I know of, but it may be interesting to

  • see which functions take up space
  • notice if the binary size suddenly increases

It is really quick to run, less than a minute.

However, I do not really know how to present the result and/or possibly act on it, seedjarek/bloaty-analyze#1

@jkeiser
Copy link
Member

It's definitely a good idea to keep track of size over time ... that affects the ability to distribute.

Not part of this at ALL, but someday it'll be nice to do a sizecomparison--instead of just comparing simdjson against other libraries for speed on certain tasks, make a separate executable for each library+task combo and comparesize as well.

@pauldreik
Copy link
MemberAuthor

Would a reasonable small example be one that takes the twitter json and outputs the first tweet found that contains "cats" ?

I think there are several metrics interesting to keep track of over time

  • lines of code in total
  • fuzz coverage (I have amanually updated table here)
  • unit test coverage
  • performance (N platforms x M benchmarks)
  • binary size of the library
  • binary size of "hello world" similar to what@jkeiser proposes above

There was discussion of tracking performance earlier, perhaps it would be possible to store all these metrics somewhere?

Thecurl project tracks all sorts of things over time, we might get inspiration there.

matthargett reacted with thumbs up emoji

@jkeiser
Copy link
Member

jkeiser commentedDec 22, 2020
edited
Loading

For some reason I didn't see your response: I think it's reasonable to run this on simdjson.so at a minimum, and perhaps the parse executable.

For ondemand, perhaps the partial_tweets benchmarks? Perhaps benchmark_ondemand as a whole, which would potentially give us interesting comparisons.

@jkeiser
Copy link
Member

@pauldreik I'm fine leaving this pr around if you plan to get back to it; otherwise let's file an issue and get back to it when we have time :)

@pauldreik
Copy link
MemberAuthor

@pauldreik I'm fine leaving this pr around if you plan to get back to it; otherwise let's file an issue and get back to it when we have time :)

I pinged the author of the bloaty action job, let's see if I get a response and if not, let's do as you suggest!

@pauldreik
Copy link
MemberAuthor

@jkeiser I fixed the bloaty job and it seems to work, but what should we do with the results? should we reject the pull request if the binary size increases more than X%?

@jkeiser
Copy link
Member

@pauldreik do you have any idea whether the results of this are generally stable? If so, I think it'd be reasonable to reject changes with a 20% size change (or at least flag the crap out of them).@lemire thoughts?

At the very, very least, we should run this in CI so we can golook at the results when we're worried. If it's expensive we can restrict to just master pushes.

@lemire
Copy link
Member

@jkeiser Sure, sure.

@pauldreik
Copy link
MemberAuthor

pauldreik commentedJun 27, 2021 via email

I do not know if the results are stable, I do not understand why theywouldn't be?20% seems like a pretty big margin, let's start with that!

@jkeiserjkeiser changed the titleDON'T MERGE binary bloat analysis[WIP] binary bloat analysisJun 28, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pauldreik@jkeiser@lemire

[8]ページ先頭

©2009-2025 Movatter.jp