- Notifications
You must be signed in to change notification settings - Fork406
Raise exception for instance_or_null#632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
When the wrong data type is passed to the method, like a list or string,an exception is returned. Instead, we should be raising the exception.I added a single unit test, which asserts that an error is raised.Fixessigmavirus24#628 andsigmavirus24#627.
I'll recheck those flake8 jobs after I release Flake8 3.0.2 tonight. Thanks@itsmemattchung! |
Weird. Running the tests (flake8), locally, succeeds. When travis runs, however, the tests fail. I'll dig deeper; not sure why at the moment. |
Got it, thanks@sigmavirus24 . Just noticed that I'm running flake8 2.6.2, locally, while travis runs flake8 3.0.1. Good catch. |
When the wrong data type is passed to the method, like a list or string,
an exception is returned. Instead, we should be raising the exception.
I added a single unit test, which asserts that an error is raised.
Fixes#628 and
#627.