Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix cp from readonly source#870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nfischer merged 3 commits intomasterfromfix-copy-readonly
Jul 10, 2018
Merged

Fix cp from readonly source#870

nfischer merged 3 commits intomasterfromfix-copy-readonly
Jul 10, 2018

Conversation

@nfischer
Copy link
Member

This is a redo of PR#555.

This rebases, cleans up a test, and fixes a bug (the original PR usesfs.chown() instead offs.chownSync()).

Fixes#98

@nfischernfischer added the fixBug/defect, or a fix for such a problem labelJul 4, 2018
@nfischernfischer self-assigned thisJul 4, 2018
@nfischernfischer requested a review fromfreitagbrJuly 4, 2018 04:52
@codecov-io
Copy link

codecov-io commentedJul 4, 2018•
edited
Loading

Codecov Report

Merging#870 intomaster willincrease coverage by<.01%.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff            @@##           master    #870      +/-   ##=========================================+ Coverage    95.8%   95.8%   +<.01%=========================================  Files          34      34                Lines        1262    1263       +1     =========================================+ Hits         1209    1210       +1  Misses         53      53
Impacted FilesCoverage Δ
src/cp.js86.4% <100%> (+0.1%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update1dd437e...bedc538. Read thecomment docs.

@nfischer
Copy link
MemberAuthor

@freitagbr ready for review. Please review commit-by-commit (My commits are separate from the original PR's commits). The original PR essentially had my LGTM.

Copy link
Contributor

@freitagbrfreitagbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@nfischernfischer merged commit131b88f intomasterJul 10, 2018
@nfischernfischer added this to thev0.8.x milestoneJul 12, 2018
@nfischernfischer deleted the fix-copy-readonly branchDecember 7, 2023 07:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@freitagbrfreitagbrfreitagbr approved these changes

Assignees

@nfischernfischer

Labels

fixBug/defect, or a fix for such a problem

Projects

None yet

Milestone

v0.8.x

Development

Successfully merging this pull request may close these issues.

cp does not recursively copy from readonly location

5 participants

@nfischer@codecov-io@freitagbr@Fransz
[8]ページ先頭
©2009-2025 Movatter.jp