NotificationsYou must be signed in to change notification settings
Fork744
Star14.4k

chore(appveyor): do not use latest npm#847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nfischer merged 1 commit intomasterfromchore-appveyor-npm-version

May 10, 2018

Merged

chore(appveyor): do not use latest npm#847

nfischer merged 1 commit intomasterfromchore-appveyor-npm-version

May 10, 2018

Conversation

Copy link

Member

nfischer commentedMay 9, 2018

This changes appveyor from using the latest npm version to only using
the preinstalled npm version. This is safer, because it's guaranteed to
be a compatible version.

Fixes#844

chore(appveyor): do not use latest npm

6542ebd

This changes appveyor from using the latest npm version to only usingthe preinstalled npm version. This is safer, because it's guaranteed tobe a compatible version.Fixes#844

nfischer added the chore label

May 9, 2018

nfischer assignedfreitagbr

May 9, 2018

nfischer requested a review fromfreitagbr

May 9, 2018 04:25

nfischer added the high priority label

May 9, 2018

Copy link

codecov-io commentedMay 9, 2018•
edited
Loading

Codecov Report

Merging#847 intomaster willnot change coverage.
The diff coverage isn/a.

@@          Coverage Diff           @@##           master    #847   +/-   ##======================================  Coverage    95.8%   95.8%           ======================================  Files          34      34             Lines        1262    1262           ======================================  Hits         1209    1209             Misses         53      53

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update97a4df8...6542ebd. Read thecomment docs.

freitagbr approved these changes

May 9, 2018

View reviewed changes

Copy link

Contributor

freitagbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link

MemberAuthor

nfischer commentedMay 10, 2018

I'm landing this, because we need to fix master ASAP. However, there's a caveat to this change:npm recommends npm@3 on Windows, however this change bumps the node4 bot down to npm@2.15.11.

It's not clear if this causes correctness issues. This may merit further investigation.