- Notifications
You must be signed in to change notification settings - Fork744
test: add test coverage for some globOptions#1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedJun 14, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #1163 +/- ##======================================= Coverage 97.27% 97.27% ======================================= Files 36 36 Lines 1360 1360 ======================================= Hits 1323 1323 Misses 37 37 ☔ View full report in Codecov by Sentry. |
e4e6753 to989d34fCompareNo change to logic. This adds test coverage support for all of theglobOptions which share the same name between node-glob and fast-glob.Seehttps://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-globIssue#828
nfischer added a commit that referenced this pull requestJun 14, 2024
No change to logic. This adds tests for more `config.globOptions`values. This aims to cover the options which appear to be supported byboth node-glob and fast-glob, however the options have different namesin each module. This is a followup to PR#1163.Seehttps://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-globIssue#828
nfischer added a commit that referenced this pull requestJun 14, 2024
No change to logic. This adds tests for more `config.globOptions`values. This aims to cover the options which appear to be supported byboth node-glob and fast-glob, however the options have different namesin each module. This is a followup to PR#1163.Seehttps://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-globIssue#828
nfischer added a commit that referenced this pull requestJun 14, 2024
No change to logic. This adds tests for more `config.globOptions`values. This aims to cover the options which appear to be supported byboth node-glob and fast-glob, however the options have different namesin each module. This is a followup to PR#1163.Seehttps://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-globIssue#828
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No change to logic. This adds test coverage support for all of the globOptions which share the same name between node-glob and fast-glob.
Seehttps://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-glob
Issue#828