NotificationsYou must be signed in to change notification settings
Fork744
Star14.4k

Feature: Expose Error Code#1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nfischer merged 3 commits intoshelljs:masterfromJessieFrance:expose-error-code

Jan 15, 2022

Merged

Feature: Expose Error Code#1036

nfischer merged 3 commits intoshelljs:masterfromJessieFrance:expose-error-code

Jan 15, 2022

Conversation

Copy link

Contributor

JessieFrance commentedJun 24, 2021

This PR is for part of#1013, and aims to implementshell.errorCode(), similar toshell.error(). Please let me know if you'd like me to change something, and thank you for the chance to work on a new ShellJS feature!

JessieFrance added2 commits

June 24, 2021 14:12

feat: expose error code

51de362

use errorCode() in a test

f4c9643

Copy link

codecov-commenter commentedJun 24, 2021•
edited
Loading

Codecov Report

Merging#1036 (6d6a8f9) intomaster (79ae14d) willdecrease coverage by1.48%.
The diff coverage is100.00%.

❗ Current head6d6a8f9 differs from pull request most recent head90e8c8c. Consider uploading reports for the commit90e8c8c to get more accurate results

@@            Coverage Diff             @@##           master    #1036      +/-   ##==========================================- Coverage   97.14%   95.65%   -1.49%==========================================  Files          35       36       +1       Lines        1332     1336       +4     ==========================================- Hits         1294     1278      -16- Misses         38       58      +20

Impacted Files	Coverage Δ
shell.js	`100.00% <100.00%> (ø)`
src/errorCode.js	`100.00% <100.00%> (ø)`
src/rm.js	`85.07% <0.00%> (-11.95%)`	⬇️
src/cp.js	`86.40% <0.00%> (-4.80%)`	⬇️
src/test.js	`95.23% <0.00%> (-4.77%)`	⬇️
src/ln.js	`96.87% <0.00%> (-3.13%)`	⬇️
src/cmd.js	`97.05% <0.00%> (-2.95%)`	⬇️
src/mkdir.js	`94.44% <0.00%> (-2.78%)`	⬇️
src/chmod.js	`87.05% <0.00%> (-2.36%)`	⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update79ae14d...90e8c8c. Read thecomment docs.