Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update ls with glob example.#1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nfischer merged 1 commit intoshelljs:masterfromsmack0007:patch-2
Sep 3, 2020
Merged

Update ls with glob example.#1006

nfischer merged 1 commit intoshelljs:masterfromsmack0007:patch-2
Sep 3, 2020

Conversation

@smack0007
Copy link
Contributor

Adding an example of using ls with globs. Will generate the README soon.

@smack0007smack0007 changed the titleWIP: Update ls.jsUpdate ls with glob example.Aug 28, 2020
@smack0007
Copy link
ContributorAuthor

I just added an example of using a glob pattern with ls. As a windows user this wasn't immediately obvious to me.

@smack0007
Copy link
ContributorAuthor

I took a look at the failed builds and I have no idea what to do. I only added a single comment to a function's description and regenerated the docs. Please advise.

@nfischer
Copy link
Member

It looks like you did everything right, but maybe the test has become flaky. Can you trigger a rebuild of the PR? I can't find the "rebuild" button in the Travis UI anymore.

The "brute force" way to trigger a rebuild is togit commit --amend --no-edit && git push -f origin patch-2 (from your local branch).

Copy link
Member

@nfischernfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is otherwise fine. If you can't easily trigger a Travis rebuild, I'll look at merging this as-is.

@codecov-commenter
Copy link

codecov-commenter commentedSep 2, 2020
edited
Loading

Codecov Report

Merging#1006 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master    #1006   +/-   ##=======================================  Coverage   97.22%   97.22%           =======================================  Files          35       35             Lines        1332     1332           =======================================  Hits         1295     1295             Misses         37       37
Impacted FilesCoverage Δ
src/ls.js100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea8452b8...20af141. Read thecomment docs.

Adding example of using ls with globs.
@nfischernfischer merged commitba5d782 intoshelljs:masterSep 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nfischernfischernfischer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smack0007@nfischer@codecov-commenter

[8]ページ先頭

©2009-2025 Movatter.jp