- Notifications
You must be signed in to change notification settings - Fork352
pull request for issue 78#93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedAug 29, 2017
Codecov Report
@@ Coverage Diff @@## master #93 +/- ##============================================- Coverage 98.87% 98.79% -0.08%- Complexity 202 222 +20============================================ Files 3 4 +1 Lines 4183 4245 +62 Branches 55 66 +11 ============================================+ Hits 4136 4194 +58 Misses 24 24- Partials 23 27 +4
Continue to review full report at Codecov.
|
shekhargulati commentedSep 1, 2017
@flube2 I have started review of this PR. Will try to do it by EOD |
flube2 commentedSep 21, 2017
Ok let me know if there are any changes you would like me to make |
For a software design class we were to write a patch, whether it was accepted or not. Due to this, we implemented the code for this issue before submitting a pull request. If changes are needed, let me know.
StrmanTests.java - Test cases created and added to file
NumberFormatOptions.java - Created for implementing formatting options
Strman.java - formatNumber() implemented
The only huge deviation so far is that the desired argument passed to the formatNumber() function was listed on shekargulati/strman-java as type "long". This will not work with decimal numbers. Changing it to "double" solves all problems that we had encountered.