- Notifications
You must be signed in to change notification settings - Fork3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix/check for attribute to extract colors#4017
Merged
CloseChoice merged 2 commits intoshap:masterfromfabianliebig:fix/check_for_subclass_to_extract_colorsMar 14, 2025
Merged
Fix/check for attribute to extract colors#4017
CloseChoice merged 2 commits intoshap:masterfromfabianliebig:fix/check_for_subclass_to_extract_colorsMar 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Since not all subclasses of the mathplotlib base class `matplotlib.colors.Colormap` has the attribute `color`. Therefore the instance check is appended to also check the existence of that attribute if it is base on `Colormap`.
…olor values with data
@fabianliebig Thanks, this looks great. If the last test passes, I'll merge this. Don't worry about the macos test, this has nothing to do with your changes. |
@fabianliebig Thanks a lot for your efforts. Happy to see you contribute to shap |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds further checks to avoid AttributeError.
The
beeswarmfunction checks the if the givencoloris of typematplotlib.colors.Colormapin one else path of the function and access the attributecolorsif that check is true (it is in line454). However, not all subtypes ofmatplotlib.colors.Colormaphave that attribute (see this [discussion])(https://stackoverflow.com/questions/59395038/why-the-structure-of-matplotlibs-color-maps-differ). Therefore this PR just add a further attribute check as well as a test, assuming that the type check should persist.Checklist