Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix fromsql for domains#1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
zacknewman wants to merge2 commits intosfackler:master
base:master
Choose a base branch
Loading
fromzacknewman:master

Conversation

zacknewman
Copy link

Fixes#1188.

@sfackler
Copy link
Owner

Can you add a test for the case that was failing before this fix?

@zacknewman
Copy link
Author

Added a test.

@zacknewman
Copy link
Author

zacknewman commentedFeb 5, 2025•
edited
Loading

@sfackler, ping. Is it possible this gets merged? Currently one has to maintain their own fork that isn't affected by this bug, manually implementFromSql instead ofderiveing it, or live without the ability to construct certain types in PostgreSQL (which ideally would be documented at least). Can I improve the PR somehow?

@ZakSingh
Copy link

Would really love to see this merged! Ran into this issue recently.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unreachable code entered whenSELECTing nested composite types andDOMAINs
3 participants
@zacknewman@sfackler@ZakSingh
[8]ページ先頭
©2009-2025 Movatter.jp