Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork495
Support build on wasm32#1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
We already test that the crate compiles against wasm32:https://github.com/sfackler/rust-postgres/blob/master/.github/workflows/ci.yml#L50-L75. If tokio gains direct wasm32 support I'd be happy to expand the supported feature set here, but I don't want to make changes that only work when building against an unspecified tokio fork. |
This is not specific to a particular tokio; it’s just that this crate does not define KeepaliveConfig in wasm32. I’ve ignored all references to KeepaliveConfig in wasm32, and I believe these changes are reasonable. |
The |
I am pretty sure that my changes work with standard tokio. Your CI still passes with this PR. |
Signed-off-by: csh <458761603@qq.com>
In this line, the parameter KeepaliveConfig is ignored when compiled to wasm32, while there is no corresponding conditional compilation elsewhere. Therefore, I added a conditional compilation for wasm32 in the places where Keepalive is needed. This modification allows the crate to be used normally in wasm32 after replacing the underlying tokio with a patch.