- Notifications
You must be signed in to change notification settings - Fork22
v1.0.0-alpha#188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
v1.0.0-alpha#188
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- changed organisation and package name- updated maintainers- removed previous code items- updated toolsSigned-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
JBBianchi commentedJul 31, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I think the branch reached a mature enough state for code review. TheREADME has been updated to match the new API and I added aTooling Architecture document to describe how the SDK is built. Any input or help is welcome ❤️ |
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Prevents accessing a property which is declared in one type but not the other:```type A = { p: string; }; type B = { k: number; };const foo = {} as A | B;foo.p = "bar";//>Property 'p' does not exist on type 'A | B'.//> Property 'p' does not exist on type 'B'.```Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>…t in the toolingSigned-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Allows to validate an item against the workflow, for instance a transition, the use of a a function, ...Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
chakrabar commentedJan 10, 2025
Hello. Is there any plan to merge it and have a newer version of the TS SDK released supporting spec version |
@chakrabar Thank you for your interest! Yes, there are plans to move forward, but we don't have a definitive timeline at the moment. Ideally, we’d like to enhance theunit tests and add some examples to ensure a solid foundation. I'll do my best to make progress in the coming days, depending on my availability. In the meantime, please feel free to contribute if you'd like to tackle any tasks—we’d greatly appreciate your help! |
- Readded browser and node examples- Added call async api/grpc/function testsSigned-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
- Fixed the builders output type- Added more samplesSigned-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great to me! Cheers ❤️
0fa8f89 intoserverlessworkflow:mainUh oh!
There was an error while loading.Please reload this page.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Support for v1.0.0-alpha (#186)
Special notes for reviewers:
Type generation for schema is very unstable, a small change in the spec can have a big impact on the generated types and underlying validators, classes and builders.
Classes are empty. It's just a trick to maybe have some kind of runtime type checking (see builders tests).
Additional information (if needed):
Currently uses a manually modified version of the spec's JSON Schema. Yield completely different results otherwise.