Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Another set of fixes fixes for the graph/state machine generation functionality#34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

oEscal
Copy link
Contributor

This PR adds multiple bug fixes for the feature implemented in#30:

  • The initial state of the state machine was obtained as the first state listed in the workflow. This was because the code in the TypeScript SDK was implemented in this manner. Now, the code checks for thestart state.
  • Whenever a parallel state was the first one in the workflow, the state machine generator would throw an error. This was because the code was not creating the state in that specific case.

…ion when it is the first state in the machineSigned-off-by: Pedro Escaleira <pedroescaleira@hotmail.com>
@oEscal
Copy link
ContributorAuthor

@cdavernas I am very sorry for these late changes, but I am detecting these bugs as I am testing weirder things using the SDK.

cdavernas reacted with thumbs up emoji

@cdavernas
Copy link
Member

@oEscal Come on, no worries! Thanks for your awesome contributions!

oEscal reacted with laugh emoji

Copy link
Member

@cdavernascdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Cheers ❤️

@cdavernascdavernas merged commitfd4379f intoserverlessworkflow:mainJul 2, 2025
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cdavernascdavernascdavernas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@oEscal@cdavernas
[8]ページ先頭
©2009-2025 Movatter.jp