Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Multiple fixes for the graph/state machine generation functionality#33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cdavernas merged 4 commits intoserverlessworkflow:mainfromATNoG:bug/branch-initials
Jun 27, 2025

Conversation

oEscal
Copy link
Contributor

This PR adds multiple bug fixes for the feature implemented in#30:

  • The parallel state did not have any initial state in the state machine.
  • When creating the parallel state in the state machine, the code was creating double the transitions for its actions.
  • When the parallel state had branches with subflows, it was creating an empty state apart from the state with all subflow.
  • In actions, with one or more subflows and one or more functions, the code was not creating the transitions between the subflows' states and the functions' states.
  • Renamed thesource_code method (legacy from the TypeScript JDK) togenerate.

Signed-off-by: Pedro Escaleira <pedroescaleira@hotmail.com>
…hen the generate_actions_info already calls it (double calling)Signed-off-by: Pedro Escaleira <pedroescaleira@hotmail.com>
…here the machine state is a branch in parallel statesSigned-off-by: Pedro Escaleira <pedroescaleira@hotmail.com>
…n in the set of its actions; also renamed the source_code function to generateSigned-off-by: Pedro Escaleira <pedroescaleira@hotmail.com>
Copy link
Member

@cdavernascdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Cheers ❤️

oEscal reacted with rocket emoji
@cdavernascdavernas merged commitee0a9ca intoserverlessworkflow:mainJun 27, 2025
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cdavernascdavernascdavernas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@oEscal@cdavernas
[8]ページ先頭
©2009-2025 Movatter.jp