- Notifications
You must be signed in to change notification settings - Fork294
Add option for copying dependencies instead of creating a link#685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@Psycholive - I have some comments, it also would be good to cover that functionality with a test case
README.md Outdated
| ```yaml | ||
| custom: | ||
| pythonRequirements: | ||
| useFinalCopy: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure if this property name is a great choice here - it doesn't really convey the meaning in my opinion - maybe we could use something more descriptive? LikeuseSymlinks: false or something along those lines? What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Property naming is always a difficult task :) Why notuseSymlinks indeed.
README.md Outdated
| Before final packaging, a link is created in .serverless folder for python dependencies. | ||
| If it is not possible to create a symbolic link, dependencies can be copied instead of linked | ||
| whith the foloowing option: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
multiple typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Indeed.
Hey@Psycholive - sorry for not responding for a long time. Do you still have time to finalize this PR? |
I have a case where a windows folder containing sources is mounted in a linux VM and therefore symlinks cannot be created in .serverless folder.
This PR add a new option to copy dependencies in .serverless folder instead of creating a symlink. It is less beautiful and quick but it is the only option I see in my case.
It is possible to include this option in next release?