Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add native deduplication to flake checks#330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
weriomat wants to merge1 commit intoserokell:master
base:master
Choose a base branch
Loading
fromweriomat:dedup_flake_check

Conversation

@weriomat
Copy link
Contributor

this shouldfix#318 by deduplicating the flake paths with a Hashset

this should fix [serokell#318](serokell#318)by deduplicating the flake paths with a Hashset
Copy link

@Sntx626Sntx626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This does not de-duplicate all flake checks, just flake checks from having the same node provided multiple times...

What is the use-case for this?

@weriomat
Copy link
ContributorAuthor

Currently, if I deploy multiple nodes from a single repo (i.e.deploy --targets .#a .#b) it should runnix flake check . for each node/ path for the node. Thus, it should be run two times, my attempt is to deduplicate by the path such as it will only get run once regardless of the amount of nodes deployed from that repo.
That is my understanding of the issue described in#318.
Have I missed something?

Copy link

@Sntx626Sntx626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see, in this case I partially misunderstood the purpose of this PR in my previous comment.

I tested this after applying#341 to be able to pass multiple deployment--targets.
It works as described, though it still evaluates the same flake for multiple hosts.

Fixes the problem described.
LGTM

@weriomat
Copy link
ContributorAuthor

Hey what exactly do you mean by evaluating? Evaluating the configuration of the particular host, i.e. the system config or doing thenix flake check?

@Sntx626
Copy link

Sntx626 commentedOct 2, 2025
edited
Loading

I'm getting multiple evaluations of the same flake (. in this case):

$ deploy --targets .#aux .#backup .#mail .#mon .#web🚀 ℹ️ [deploy] [INFO] Running checks for flake in .warning: unknown flake output 'deploy'warning: The check omitted these incompatible systems: aarch64-darwin, aarch64-linux, x86_64-darwinUse '--all-systems' to check all.🚀 ℹ️ [deploy] [INFO] Evaluating flake in .🚀 ℹ️ [deploy] [INFO] Evaluating flake in .🚀 ℹ️ [deploy] [INFO] Evaluating flake in .🚀 ℹ️ [deploy] [INFO] Evaluating flake in .🚀 ℹ️ [deploy] [INFO] Evaluating flake in ....

I'm referring to the multiple evaluations thatshould also be able to be de-duplicated, since one evaluation per flake should result in all nodes.

@weriomat
Copy link
ContributorAuthor

That is a misconception on your part. For each node/ profile the nixosConfiguration (via. outputs.nixosConfiguration.config.system.build.toplevel`) is evaluated in that step. As deploy-rs does not know anything about this configuration it cannot assume that the configuration is the same across the nodes/ profiles.
In essence, it could be evaluated in a singe step (for all requested host) instead of for each once, but that complicates the design of the program, the speed-up is not huge and is therefore not used.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@Sntx626Sntx626Sntx626 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Checks are repeated several times

2 participants

@weriomat@Sntx626

[8]ページ先頭

©2009-2025 Movatter.jp