- Notifications
You must be signed in to change notification settings - Fork137
add support for asynchronous building and pushing of profiles#271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
PhilTaken wants to merge8 commits intoserokell:masterChoose a base branch fromPhilTaken:phil/async-build-and-push
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
91ce286 build and push profiles asynchronously
PhilTakena70a339 group remote builds by host
PhilTakenc00037e continue building when a remote build fails and report errors afterwards
PhilTaken42ae995 add indicatif progress indicators for remote and local builds
PhilTaken02b9681 wrap the logger with a custom implementation
PhilTaken7fa8db8 improved errer handling for async deployments
PhilTaken2483a1e change: address pr feedback (squash this commit)
PhilTakenb20db77 feat: checkmarks (success) / red cross (error) indicators for finishe…
PhilTakenFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
wrap the logger with a custom implementation
the custom implementation handles indicatif's progressbars better so as to notleave orphaned progress bar fragments when logging while a progressbar is active
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit02b9681f7eddd2d386158eb5d36ad933a5d2fb88
There are no files selected for viewing
7 changes: 4 additions & 3 deletionssrc/cli.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
68 changes: 62 additions & 6 deletionssrc/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.