- Notifications
You must be signed in to change notification settings - Fork46
Update SDK and targets to match Serilog 3#54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Permissions have now been updated
1.1.0 Release
updated packages in test proj
nblumhardt left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for this! It might be best to re-title the PR "Update SDK and targets to match Serilog 3", as the library already supports .NET 6 as-is.
Spotted a few things but otherwise think this is on the right track 👍
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
test/Serilog.Formatting.Compact.Tests/Serilog.Formatting.Compact.Tests.csproj OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as duplicate.
This comment was marked as duplicate.
ghost commentedJul 10, 2023
Hi, good to read that the direction is good and thanks for feedback :-) I put the changes, makes sense. Question, what do you thing about skipping net50 because of warning: For a possible next version what do you think about replacing dependencies to Newtonsoft.Json and Newtonsoft.Json.Linq by System.Text.Json and System.Linq ? |
…s table [skip ci], from commit06ef9d8
ghost commentedJul 11, 2023
@nblumhardt |
ghost commentedJul 17, 2023
@nblumhardt |
nblumhardt commentedJul 19, 2023
Thanks @pmetz-steelcase 👍 |
ghost commentedJul 20, 2023
@nblumhardt Question, as I have to close my account pmetz-steelcase, now after it's merged I candeletemy repo pmetz-steelcase:devNet6 (https://github.com/pmetz-steelcase/serilog-formatting-compact/tree/devNet6) ? |
nblumhardt commentedJul 20, 2023
I don't think that will cause any problems - thanks Peter! |
updated targets to NET60 and netstandard2.0
updated to serilog 3.0.1
updated nuget pckgs in test proj