Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update SDK and targets to match Serilog 3#54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nblumhardt merged 27 commits intoserilog:devfromunknown repositoryJul 19, 2023
Merged

Update SDK and targets to match Serilog 3#54

nblumhardt merged 27 commits intoserilog:devfromunknown repositoryJul 19, 2023

Conversation

@ghost
Copy link

updated targets to NET60 and netstandard2.0
updated to serilog 3.0.1
updated nuget pckgs in test proj

Copy link
Member

@nblumhardtnblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this! It might be best to re-title the PR "Update SDK and targets to match Serilog 3", as the library already supports .NET 6 as-is.

Spotted a few things but otherwise think this is on the right track 👍

@ghost

This comment was marked as duplicate.

@ghostghost changed the titleNET6 supportUpdate SDK and targets to match Serilog 3Jul 10, 2023
@ghost
Copy link
Author

Hi, good to read that the direction is good and thanks for feedback :-)

I put the changes, makes sense.

Question, what do you thing about skipping net50 because of warning:
NETSDK1138: The target framework 'net5.0' is out of support and will not receive security updates


For a possible next version what do you think about replacing dependencies to Newtonsoft.Json and Newtonsoft.Json.Linq by System.Text.Json and System.Linq ?
I'd like to have less dependencies to other third party libraries and I do expect some performance improvement from System.Text.Json
I think about a proposal how to change that, if there is "green light" for that idea, I'll have a look into that :-)

@ghost
Copy link
Author

@nblumhardt
just merged manually changes from dev, there are no changes on the C# code, only readme, publishing key, ...
let me know if you may spot something else :-)
thanks

@ghost
Copy link
Author

@nblumhardt
Hi, I have to close the account the next days. Is there anything to change on my PR? Or you might just take my branch into your Repo?
Let me know please, anyway the changes are no "rocket science" :-)
Cheers

@nblumhardtnblumhardt changed the base branch frommain todevJuly 19, 2023 21:46
@nblumhardt
Copy link
Member

Thanks @pmetz-steelcase 👍

@ghost
Copy link
Author

@nblumhardt
Happy that I could help somehow. Serilog is (not only -) in my opinion the best choice for logging in .NET C#

Question, as I have to close my account pmetz-steelcase, now after it's merged I candeletemy repo pmetz-steelcase:devNet6 (https://github.com/pmetz-steelcase/serilog-formatting-compact/tree/devNet6) ?

@nblumhardt
Copy link
Member

I don't think that will cause any problems - thanks Peter!

@ghost ghost deleted the devNet6 branchJuly 20, 2023 06:25
@nblumhardtnblumhardt mentioned this pull requestNov 9, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nblumhardt

[8]ページ先頭

©2009-2025 Movatter.jp