Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork158
feat(console-reporter): Generating code snippets on error#2270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
In1th commentedMar 4, 2024
@jan-molak I did a base version, but I have to ask you - are stack format library independent? Because if that's not the case, then we need parser for every one of them. (also you tried to chat with me on serenity chat, but there were some encryption issue) |
jan-molak commentedMar 4, 2024
Hey@In1th - you can use the existing |
| ProblemIndication, | ||
| }from'@serenity-js/core/lib/model'; | ||
| import{InstanceasChalkInstance}from'chalk';// eslint-disable-line unicorn/import-style | ||
| importtype{FileSystem}from'packages/core/lib/io'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You'll want@serenity-js/core/lib/io instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yeah, I noticed vs code is not doing great with this repo 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I wonder what causes it 🤔
In1th commentedMar 7, 2024
Ok I have done some refactoring and added a flag to add tests for snippets, but I don't see any integration test using console reporter. Should I add a new integration test project for that or did I miss anything? |
jan-molak commentedMar 9, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Console reporter is reasonably simple and doesn't require a separate integration test module. The best way to test it is to pump a stream of events into it and then assert on the output. To generate a stream of events you can:
Since the events generated by all the test runners are identical, we don't need to test the console reporter with each test runner, just with the events. |
In1th commentedMar 19, 2024
jan-molak commentedMar 21, 2024
@In1th - Looks awesome, great work so far! |

Uh oh!
There was an error while loading.Please reload this page.
#2244