Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork158
feat(interaction): make scroll interaction configurable#1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
310d1fd to4539392Comparenow it is possible to set where to place the element to be scrolled within the visible area
damonpam commentedJun 21, 2022
@jan-molak@viper3400 feel free to suggest, reword, etc. this is ready for review. |
jan-molak commentedJun 22, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks@damonpam! We'll need to think about how this should work with the upcoming Playwright integration; Playwright's scroll function doesn't take any arguments, because it seems to be smarter than what WDIO and Selenium do - check out From what I understand, they rely on theIntersection Observer API to figure out if scrolling is necessary. I wonder if what we should do is to make our I'll be in this area of code later on today/tomorrow so will have a think and let you know if that's OK? By the way, I need to see if we can use the Intersection Observer API to perform visibility checks, maybe it could help to simplifythis logic. |
now it is possible to set where to place the element to be scrolled within the visible area