Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(interaction): make scroll interaction configurable#1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
damonpam wants to merge1 commit intoserenity-js:main
base:main
Choose a base branch
Loading
fromdamonpam:main

Conversation

@damonpam
Copy link
Contributor

now it is possible to set where to place the element to be scrolled within the visible area

@damonpamdamonpam marked this pull request as draftJune 21, 2022 13:04
@damonpamdamonpamforce-pushed themain branch 3 times, most recently from310d1fd to4539392CompareJune 21, 2022 13:42
@damonpamdamonpam marked this pull request as ready for reviewJune 21, 2022 14:12
now it is possible to set where to place the element to be scrolled within the visible area
@damonpam
Copy link
ContributorAuthor

@jan-molak@viper3400 feel free to suggest, reword, etc. this is ready for review.

@jan-molakjan-molak self-assigned thisJun 22, 2022
@jan-molakjan-molak added the @serenity-js/webScreenplay Pattern APIs for interacting with the Web labelJun 22, 2022
@jan-molak
Copy link
Member

jan-molak commentedJun 22, 2022
edited
Loading

Thanks@damonpam! We'll need to think about how this should work with the upcoming Playwright integration; Playwright's scroll function doesn't take any arguments, because it seems to be smarter than what WDIO and Selenium do - check outscrollIntoViewIfNeeded

From what I understand, they rely on theIntersection Observer API to figure out if scrolling is necessary.

I wonder if what we should do is to make ourScroll.to configurable and ignore this configuration for Playwright, or instead make ourScroll.to use the Intersection Observer API and improve on how WDIO and Selenium behave out of the box 🤔

I'll be in this area of code later on today/tomorrow so will have a think and let you know if that's OK?

By the way, I need to see if we can use the Intersection Observer API to perform visibility checks, maybe it could help to simplifythis logic.

@jan-molakjan-molak removed their assignmentDec 12, 2022
@jan-molakjan-molak added the developer experienceImprovements to the developer experience of using Serenity/JS labelJun 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

developer experienceImprovements to the developer experience of using Serenity/JS@serenity-js/webScreenplay Pattern APIs for interacting with the Web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@damonpam@jan-molak

[8]ページ先頭

©2009-2025 Movatter.jp