Commitd9e0728

authored

fix: throw if where receives an invalid value (#15699)

1 parent48d6193 commitd9e0728Copy full SHA for d9e0728

File tree

+15

-1

lines changed

+15

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2833,7 +2833,7 @@ class QueryGenerator {`
`2833`	`2833`	`});`
`2834`	`2834`	`}`
`2835`	`2835`
`2836`		`-return'1=1';`
	`2836`	+thrownewError(`Unsupported where option value:${util.inspect(smth)}. Please refer to the Sequelize documentation to learn more about which values are accepted as part of the where option.`);
`2837`	`2837`	`}`
`2838`	`2838`
`2839`	`2839`	`// A recursive parser for nested where conditions`

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,14 @@`
	`1`	`+const{ expect}=require('chai');`
	`2`	`+const{ sequelize}=require('../../support');`
	`3`	`+`
	`4`	`+describe('QueryGenerator#getWhereConditions',()=>{`
	`5`	`+constqueryGenerator=sequelize.queryInterface.queryGenerator;`
	`6`	`+`
	`7`	`+it('throws if called with invalid arguments',()=>{`
	`8`	`+constUser=sequelize.define('User');`
	`9`	`+`
	`10`	`+expect(()=>{`
	`11`	`+queryGenerator.getWhereConditions(newDate(),User.getTableName(),User);`
	`12`	`+}).to.throw('Unsupported where option value');`
	`13`	`+});`
	`14`	`+});`

Comments

(0)