This repository was archived by the owner on Feb 24, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork278
Allow Symfony 6#742
Merged
Merged
Allow Symfony 6#742
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
tests/Fixtures/config/config_sf5.yml Outdated
Comment on lines 1 to 3
| security: | ||
| password_hashers: | ||
| Symfony\Component\Security\Core\User\User: plaintext |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please use four spaces for indentation
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed, thanks!
Nyholm approved these changesJul 22, 2021
Contributor
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you.
I agree with this change. I would be happy to see it merged.
Member
fabpot commentedJul 23, 2021
Thank you@Kocal. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests are failing, but that was already the case before this PR (eg: inhttps://github.com/sensiolabs/SensioFrameworkExtraBundle/runs/3084739718?check_suite_focus=true).
Unfortunately I don't know how to fix them.
Thanks!