test(integration): properly waited for the image pulls to complete#2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gr2m merged 1 commit intomasterfromdocker-pull

Jun 26, 2023

Merged

test(integration): properly waited for the image pulls to complete#2842

gr2m merged 1 commit intomasterfromdocker-pull

Jun 26, 2023

Conversation

Copy link

Member

travi commentedJun 20, 2023•
edited
Loading

this uses the technique for waiting for the pull to completefrom the dockerode readme and mostly gets rid of our dependence on get-stream.

theremaining get-stream usage is the.array() that isremoved in v7. i suggest we deal with that usage separately from this PR

travi marked this pull request as draft

June 20, 2023 04:51

Copy link

MemberAuthor

travi commentedJun 20, 2023

it appears that the pulls are happening before each test in the integration file. would be better to do the pulls before the overall suite run so that they only happen once

Copy link

MemberAuthor

travi commentedJun 20, 2023

it appears that the pulls are happening before each test in the integration file. would be better to do the pulls before the overall suite run so that they only happen once

i was wrong. it is usingtest.before, nottest.beforeEach, so this should already be correct. since we are actually fully waiting for the pulls, we may need to extend the timeout for the integration test, though