Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: get correct version if prerelease branch shares version with ...#2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Tlepel
Copy link
Contributor

@TlepelTlepel commentedApr 14, 2022•
edited by gr2m
Loading

…other branches

Fixes#2415

limulus, r4j4h, franoisD, shiipou, kkosmrli, taorepoara, jfairley, joeklos, and Dendiiip reacted with thumbs up emoji
@TlepelTlepelforce-pushed thefix-versions-share-head branch from24de2a4 to406b9adCompareApril 14, 2022 12:54
@TlepelTlepelforce-pushed thefix-versions-share-head branch from406b9ad to6d6acd3CompareApril 14, 2022 17:02
Copy link

@limuluslimulus left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey@Tlepel! Thanks for making this PR, I just happened to run into the same issue. I think I found a potential issue with this PR though. (See the code comment.)

@TlepelTlepelforce-pushed thefix-versions-share-head branch from6d6acd3 toe6ea0e2CompareApril 27, 2022 15:59
@TlepelTlepelforce-pushed thefix-versions-share-head branch 4 times, most recently from1dd1fcb to5bd7b02CompareJune 20, 2022 09:35
@TlepelTlepelforce-pushed thefix-versions-share-head branch from5bd7b02 toc480244CompareJune 29, 2022 10:31
@TlepelTlepel requested a review fromtraviJune 29, 2022 10:32
@TlepelTlepelforce-pushed thefix-versions-share-head branch fromc480244 toca4fba5CompareJuly 6, 2022 08:04
@TlepelTlepelforce-pushed thefix-versions-share-head branch fromca4fba5 to753bac8CompareJuly 15, 2022 11:38
@TlepelTlepelforce-pushed thefix-versions-share-head branch from753bac8 toa5dc2d3CompareJuly 25, 2022 08:40
@TlepelTlepelforce-pushed thefix-versions-share-head branch froma5dc2d3 to4512679CompareAugust 3, 2022 12:35
Copy link

@shiipoushiipou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@TlepelTlepelforce-pushed thefix-versions-share-head branch from4512679 toef82181CompareSeptember 5, 2022 11:26
@TlepelTlepelforce-pushed thefix-versions-share-head branch fromef82181 to445861cCompareOctober 4, 2022 10:03
@TlepelTlepelforce-pushed thefix-versions-share-head branch from445861c toc1b4646CompareOctober 12, 2022 09:09
@TlepelTlepelforce-pushed thefix-versions-share-head branch fromc1b4646 tobd378c7CompareNovember 17, 2022 09:19
@Tlepel
Copy link
ContributorAuthor

@travi whould you have time to review this PR? I try to rebase every time commits were merged tomaster, but to be fair I don't feel like keeping that going. I'd love to get some feedback if the PR is not up to standards, and improve the code if necessary, since it seems like more people might need this fix.

limulus, shiipou, taorepoara, and frnode reacted with thumbs up emoji

@TlepelTlepelforce-pushed thefix-versions-share-head branch 3 times, most recently from1665c39 to15aad9eCompareDecember 13, 2022 10:51
@taorepoara
Copy link

We use two pre-release channels on our projects: alpha and beta.

We used to have a problem since channels are stored in the tag notes: when a commit is released to the alpha channel and then the beta channel, every thing is fine, but when another commit is released to the alpha channel (if the previous is not released in the main branch), the previous alpha release is not found and it try to create another alpha release with the same version...

This PR fixes our issues.

shiipou, limulus, and Tlepel reacted with thumbs up emoji

@TlepelTlepelforce-pushed thefix-versions-share-head branch 2 times, most recently from73471f3 toda9544bCompareJanuary 16, 2023 12:22
@Langstra
Copy link

Could we get this reviewed and merged? 😇

shiipou and taorepoara reacted with thumbs up emoji

@TlepelTlepelforce-pushed thefix-versions-share-head branch fromda9544b to94b725eCompareJanuary 24, 2023 14:16
@taorepoara
Copy link

taorepoara commentedJan 24, 2023•
edited
Loading

For those who are tired to wait for this merge I found another project that could do the job: convco. They have justadded the prerelease management. It does not work the same as Semantic Release, but it should work fine.

shiipou reacted with thumbs up emojiLangstra and renestalder reacted with thumbs down emojishiipou reacted with heart emoji

@TlepelTlepelforce-pushed thefix-versions-share-head branch from94b725e toe8f6feeCompareJanuary 25, 2023 14:21
@TlepelTlepelforce-pushed thefix-versions-share-head branch frome8f6fee to1ab4f6eCompareFebruary 8, 2023 14:54
@TlepelTlepelforce-pushed thefix-versions-share-head branch from1ab4f6e tobe9e36fCompareFebruary 23, 2023 14:13
@frnode
Copy link

I have same issue... Anyone if we can work around the problem temporarily?
thank you

@taorepoara
Copy link

I have same issue... Anyone if we can work around the problem temporarily? thank you

You can use the@Tlepel version instead of the official one.

Instead of installing semantic-release official version use the next code:

npm i"https://github.com/Tlepel/semantic-release.git#fix-versions-share-head"

The problem with this solution is that the this PR isFINALLY merged, you'll have to change your CI back to the official version of semantic release, since this branch will be closed.

shiipou reacted with thumbs up emojifrnode reacted with eyes emoji

@TlepelTlepelforce-pushed thefix-versions-share-head branch frombe9e36f tofe3b22dCompareMarch 15, 2023 09:36
@Tlepel
Copy link
ContributorAuthor

@gr2m Perhaps you can have a look at this PR? It seems that quite some projects run into this issue and the fix isn't too complicated.@travi is on the list of reviewers but he hasn't reviewed this PR after his initial review on the day I created this PR.

frnode, TsaorKG, shiipou, taorepoara, Langstra, and limulus reacted with thumbs up emoji

@TlepelTlepelforce-pushed thefix-versions-share-head branch fromfe3b22d tof23984bCompareMarch 22, 2023 08:28
@TlepelTlepelforce-pushed thefix-versions-share-head branch fromf23984b tod39357cCompareMarch 31, 2023 13:25
@TlepelTlepelforce-pushed thefix-versions-share-head branch 2 times, most recently from5f85888 tod8da89bCompareApril 24, 2023 08:52
@TlepelTlepelforce-pushed thefix-versions-share-head branch fromd8da89b tof17288cCompareMay 2, 2023 07:41
@renestalder
Copy link

Is he going to break the record for the longest ever rebase run? :)

taorepoara and limulus reacted with laugh emojiLangstra and taorepoara reacted with eyes emoji

@Tlepel
Copy link
ContributorAuthor

Is he going to break the record for the longest ever rebase run? :)

I sure hope not 😅

gr2m reacted with laugh emoji

@TlepelTlepelforce-pushed thefix-versions-share-head branch fromf17288c to87c82bcCompareMay 8, 2023 12:29
@TlepelTlepelforce-pushed thefix-versions-share-head branch from87c82bc to3ebc0ddCompareMay 22, 2023 12:39
@TlepelTlepelforce-pushed thefix-versions-share-head branch from3ebc0dd to448fd3fCompareJune 21, 2023 09:37
@TlepelTlepelforce-pushed thefix-versions-share-head branch from448fd3f tod7cfe02CompareJune 28, 2023 10:12
@Langstra
Copy link

Is he going to break the record for the longest ever rebase run? :)

Looks more and more like it. Anyone any idea what the record is?

Copy link
Member

@gr2mgr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Alright sorry for the wait! We hoped to find the time to do a deeper dive into potential unwanted side effects, but at this point all your contributions (and patience) outweigh the risk. Thank you all 💐💝

Langstra, shiipou, Tlepel, and limulus reacted with hooray emoji
@gr2mgr2m merged commite4229f9 intosemantic-release:masterJun 28, 2023
@github-actions
Copy link

🎉 This PR is included in version 21.0.6 🎉

The release is available on:

Yoursemantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gr2mgr2mgr2m approved these changes

@travitraviAwaiting requested review from travi

+2 more reviewers

@limuluslimuluslimulus left review comments

@shiipoushiipoushiipou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Release picks wrong version when several previous (pre)releases share same HEAD

9 participants

@Tlepel@taorepoara@Langstra@frnode@renestalder@gr2m@travi@limulus@shiipou
[8]ページ先頭
©2009-2025 Movatter.jp