- Notifications
You must be signed in to change notification settings - Fork142
refactor(glob-assets): use 'tinyglobby' instead of 'globby' as dependency#925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
oscard0m wants to merge2 commits intosemantic-release:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
refactor(glob-assets): use 'tinyglobby' instead of 'globby' as dependency#925
oscard0m wants to merge2 commits intosemantic-release:masterfromoscard0m:replace-globby-with-tinyglobby
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
44aa7de to685d8fbCompare13db284 tobf1c91bCompare38653d2 toc1ef4f4Comparegitignore: false is the default behaviour of globby
…encyglobby@14.0.2 is 26.3kb (minified + gzipped) ->https://bundlephobia.com/package/globby@14.0.2tinyglobby@0.2.6 is 10.8kb (minified + gzipped)https://bundlephobia.com/package/tinyglobby@0.2.6and other libraries are opting for it:https://e18e.dev/blog/august-contributions-showcase#tinyglobby-fdir
c1ef4f4 to2064e1dCompareContributorAuthor
oscard0m commentedSep 13, 2024 • edited by heartsbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by heartsbot
Uh oh!
There was an error while loading.Please reload this page.
 Converted to draft as there are some tests failing. If |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
📖 Description
Replace
globbywithtinyglobbyas dependency.📚 Context
With the spirit of reducing the bundle size of semantic-release, this PR aims to replace globby with a more lightweight library:tinyglobby. Other libraries are opting for it:https://e18e.dev/blog/august-contributions-showcase#tinyglobby-fdir as a way to save bundle size.
The comparison looks like this in bundlephobia:
globby@14.0.2tinyglobby@0.2.6