Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: singletonoctokit instance for shared throttling state#640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
gr2m wants to merge4 commits intomaster
base:master
Choose a base branch
Loading
frombeta-singleton-octokit

Conversation

@gr2m
Copy link
Member

@gr2mgr2m commentedMay 29, 2023•
edited by heartsbot
Loading

babblebey reacted with heart emoji
@gr2mgr2mforce-pushed thebeta-singleton-octokit branch frome7f4f8f to15a127bCompareMay 29, 2023 23:49
@gr2mgr2mforce-pushed thebeta-singleton-octokit branch from15a127b to0893befCompareMay 30, 2023 00:02
@gr2mgr2m changed the base branch frombeta tobeta-no-more-serialMay 30, 2023 00:03
@gr2mgr2m changed the titleWIP singletonoctokit instancerefactor: singleton octokit instance for shared throttling stateMay 30, 2023
@gr2mgr2m changed the titlerefactor: singleton octokit instance for shared throttling staterefactor: singletonoctokit instance for shared throttling stateMay 30, 2023
Base automatically changed frombeta-no-more-serial tobetaMay 30, 2023 02:53
Copy link
Member

@travitravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

i like where this is headed. only comments are calling out most of your todos. am i correct to assume that is most of what remains for this to still be draft, or do you have additional plans?

});

test.serial("Update a release with a custom github url",async(t)=>{
// TODO: move to integration tests
Copy link
Member

@travitraviJun 2, 2023•
edited by heartsbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is this a change that you are wanting to include in this PR?

});

test("Publish a release with one asset and custom github url",async(t)=>{
// TODO: move to integration tests
Copy link
Member

@travitraviJun 2, 2023•
edited by heartsbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is this a change you are wanting to include in this PR?

});

test("Publish a release when env.GITHUB_URL is set to https://github.com (Default in GitHub Actions, #268)",async(t)=>{
// TODO: move to integration test
Copy link
Member

@travitraviJun 2, 2023•
edited by heartsbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is this a change you are wanting to include in this PR?

t.true(fetch.done());
});

// TODO: move to integration test
Copy link
Member

@travitraviJun 2, 2023•
edited by heartsbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is this a change you are wanting to include in this PR?

@travi
Copy link
Member

travi commentedJun 2, 2023•
edited by heartsbot
Loading

are we wanting to include this refactor in the ESM change, or follow up with it afterward? i've had no problems in my testing with the current beta that includes the ESM change for our two candidate plugins, so wondering if we promote those candidates or wait for this change to go in

@gr2m
Copy link
MemberAuthor

gr2m commentedJun 2, 2023•
edited by heartsbot
Loading

only comments are calling out most of your todos. am i correct to assume that is most of what remains for this to still be draft

correct

are we wanting to include this refactor in the ESM change, or follow up with it afterward

I planned to give this another go today but I won't have time. I'd say let's go ahead with the ESM change and then do this afterwards.

travi reacted with thumbs up emoji

Base automatically changed frombeta tomasterJune 2, 2023 19:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@travitravitravi left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gr2m@travi
[8]ページ先頭
©2009-2025 Movatter.jp