Commitf2ce01f

committed

Refactor CDP Mode

1 parentb65b725 commitf2ce01fCopy full SHA for f2ce01f

File tree

-18

lines changed

-18

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -633,7 +633,7 @@ async def start(self=None) -> Browser:`
`633`	`633`	`"""% (dashes,message,dashes)`
`634`	`634`	`)`
`635`	`635`	`self.connection=Connection(`
`636`		`-self.info.webSocketDebuggerUrl,_owner=self`
	`636`	`+self.info.webSocketDebuggerUrl,browser=self`
`637`	`637`	`)`
`638`	`638`	`ifself.config.autodiscover_targets:`
`639`	`639`	`logger.info("Enabling autodiscover targets")`
`@@ -807,7 +807,7 @@ async def update_targets(self):`
`807`	`807`	`f"/{t.target_id}"`
`808`	`808`	`),`
`809`	`809`	`target=t,`
`810`		`-_owner=self,`
	`810`	`+browser=self,`
`811`	`811`	`)`
`812`	`812`	`)`
`813`	`813`	`awaitasyncio.sleep(0)`

Lines changed: 0 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -719,18 +719,6 @@ def start_sync(args, *kwargs) -> Browser:`
`719`	`719`	`loop=kwargs["loop"]`
`720`	`720`	`else:`
`721`	`721`	`loop=asyncio.new_event_loop()`
`722`		`-if"user_data_dir"inkwargsandkwargs["user_data_dir"]:`
`723`		`-headless=False`
`724`		`-if"headless"inkwargs:`
`725`		`-headless=kwargs["headless"]`
`726`		`-decoy_args=kwargs`
`727`		`-decoy_args["headless"]=True`
`728`		`-driver=loop.run_until_complete(start(**decoy_args))`
`729`		`-kwargs["headless"]=headless`
`730`		`-kwargs["user_data_dir"]=driver.config.user_data_dir`
`731`		`-time.sleep(0.2)`
`732`		`-driver.stop()# Due to Chrome-130, must stop & start`
`733`		`-time.sleep(0.1)`
`734`	`722`	`returnloop.run_until_complete(start(args,*kwargs))`
`735`	`723`
`736`	`724`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -184,13 +184,13 @@ def __init__(`
`184`	`184`	`self,`
`185`	`185`	`websocket_url=None,`
`186`	`186`	`target=None,`
`187`		`-_owner=None,`
	`187`	`+browser=None,`
`188`	`188`	`**kwargs,`
`189`	`189`	`):`
`190`	`190`	`super().__init__()`
`191`	`191`	`self._target=target`
`192`	`192`	`self.__count__=itertools.count(0)`
`193`		`-self._owner=_owner`
	`193`	`+self.browser=browser`
`194`	`194`	`self.websocket_url:str=websocket_url`
`195`	`195`	`self.websocket=None`
`196`	`196`	`self.mapper= {}`
`@@ -426,8 +426,8 @@ async def send(`
`426`	`426`	`awaitself.aopen()`
`427`	`427`	`ifnotself.websocketorself.websocket.stateisState.CLOSED:`
`428`	`428`	`return`
`429`		`-ifself._owner:`
`430`		`-browser=self._owner`
	`429`	`+ifself.browser:`
	`430`	`+browser=self.browser`
`431`	`431`	`ifbrowser.config:`
`432`	`432`	`ifbrowser.config.expert:`
`433`	`433`	`awaitself._prepare_expert()`

Comments

(0)