Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[EventBridge Actions] - new Destination#7966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sade-wusi merged 5 commits intodevelopfromeventbridge-actions
Sep 30, 2025
Merged

Conversation

@joe-ayoub-segment
Copy link
Contributor

Proposed changes

Docs for new Destination:
Amazon EventBridge (Actions)
ID: 67be4b2aef865ee6e0484fe5

There is a Classic Destinations already. Should the docs reference each other somehow?

Merge timing

This Destination is in Private Beta - but soon to be Public Beta.

Related issues (optional)

https://twilio-engineering.atlassian.net/browse/STRATCONN-6121

Copy link
Contributor

@longstoryshortlongstoryshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have 2 suggestions:
Suggestion 1 - expand Getting Started # 7:
7. Before saving your mapping, click theCreate Partner Source button. This step creates a newEventBridge Partner Event Source in your AWS account if it does not exist yet. The source name is
aws.partner/segment.com/SEGMENT_SOURCE_ID. This step is required. Without it, data will not flow to EventBridge.

Suggestion 2 - add a note about connecting the source to event bus in AWS:
OnceEventBridge Partner Event Source is created in your AWS account, you can associate the source withEventBridge Event Bus.

joe-ayoub-segment reacted with thumbs up emoji
@stayseesong
Copy link
Contributor

@joe-ayoub-segment the actions destination doesn't need to reference the class docs. Also, do you want this merged once the destination goes to Public beta, or would you like for it to be merged while in private beta?

@stayseesongstayseesong added the new-integrationAdded a new source or destination labelSep 24, 2025
@joe-ayoub-segment
Copy link
ContributorAuthor

Hi@stayseesong
We'll probably want to go to public beta next week.
For now the doc should be hidden.

stayseesong
stayseesong previously approved these changesSep 25, 2025
@joe-ayoub-segment
Copy link
ContributorAuthor

Hi@stayseesong just wondering why this didn't merge after you approved it? Does someone else from docs also need to review?

@stayseesong
Copy link
Contributor

@joe-ayoub-segment I can't merge this in because you requested@longstoryshort as a required reviewer, so until@longstoryshort reviews this, I can't merge this in

@joe-ayoub-segment
Copy link
ContributorAuthor

Hi@stayseesong I removed@longstoryshort as a requested reviewer. Can we merge now please?

@joe-ayoub-segment
Copy link
ContributorAuthor

Hi@stayseesong can we deploy please? This Destination is moving to Public Beta now.

auto-merge was automatically disabledSeptember 30, 2025 13:01

Head branch was modified

Copy link
Contributor

@sade-wusisade-wusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few page edits but good to go!

@sade-wusisade-wusi merged commit3ed461e intodevelopSep 30, 2025
4 checks passed
@sade-wusisade-wusi deleted the eventbridge-actions branchSeptember 30, 2025 14:31
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sade-wusisade-wusisade-wusi approved these changes

@longstoryshortlongstoryshortlongstoryshort left review comments

@stayseesongstayseesongAwaiting requested review from stayseesong

Assignees

No one assigned

Labels

new-integrationAdded a new source or destination

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joe-ayoub-segment@stayseesong@longstoryshort@sade-wusi
[8]ページ先頭
©2009-2025 Movatter.jp