- Notifications
You must be signed in to change notification settings - Fork396
Updates to ecommerce-v2 [DOC-1243]#7875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
✅ Deploy Preview forsegment-docs ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
sade-wusi approved these changesSep 5, 2025
16c3f22 intodevelop 4 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
content-updateupdates to content that are not new features, includes grammar fixes, added notes
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several documentation improvements to the
src/connections/spec/ecommerce/v2.mdfile for the V2 Ecommerce Events spec. The main focus is on standardizing table formatting, clarifying language, and improving consistency across event descriptions and property definitions.Documentation formatting and consistency:
Standardized all table headers by removing bold formatting and ensuring uniform column names (e.g.,
Action,Description,Property,Type) throughout the document.[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19]Improved property descriptions for clarity and consistency, such as updating "Database id" to "Database ID" for product identifiers.[1][2]
Content and language clarity:
Removed unnecessary note formatting by replacing
> info "Note"with> info ""to standardize callout sections and avoid confusion.[1][2][3][4][5][6][7][8][9][10][11]Fixed minor typos and improved language for better readability, such as removing unnecessary articles in descriptions (e.g., "User viewed product details" instead of "User viewed a product details").
These changes collectively enhance the readability and maintainability of the documentation, making it easier for users to understand and implement the e-commerce event spec.
Proposed changes
Merge timing
Related issues (optional)
DOC-1243