- Notifications
You must be signed in to change notification settings - Fork839
correct lengthRemain handling into message_read.readMessageV2#1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Dmitriy-Kulagin wants to merge1 commit intosegmentio:mainChoose a base branch fromDmitriy-Kulagin:patch-1
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedNov 17, 2025
Open
Author
Dmitriy-Kulagin commentedNov 28, 2025
I'm pretty sure that this MR can fix several different issues that I've described in thisissue |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In topic with log compaction the incorrect handling of lengthRemain into readMessageV2 lead to endlessly reading of the same compacted batch. It is happens because skipping offset to batch.lastOffset assumes that lengthRemain ==0 but without this correction lengthRemain became negative and comparison with zero doesn't work.